Unit test not available for TunnelRpcCallbackMixin

Bug #1381071 reported by Romil Gupta
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Romil Gupta

Bug Description

Currently , there is no unit test available for TunnelRpcCallbackMixin--> tunnel_sync () method. It needs to be addressed.

https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_tunnel.py#L151

Romil Gupta (romilg)
Changed in neutron:
assignee: nobody → Romil Gupta (romilg)
description: updated
Romil Gupta (romilg)
description: updated
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134815

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/134815
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8a499ef0f8a7fa53b5a673b53188ddddea5de6f3
Submitter: Jenkins
Branch: master

commit 8a499ef0f8a7fa53b5a673b53188ddddea5de6f3
Author: Romil Gupta <email address hidden>
Date: Sun Nov 16 09:35:35 2014 -0800

    Moved out common testcases from test_type_vxlan.py

    This patch-set will refactor the test_type_vxlan.py and test_type_gre.py.

    We need to add testcases for TunnelRpcCallbackMixin() so better we
    should move common test cases from test_type_vxlan.py to test_type_tunnel.py and
    add testcases for TunnelRpcCallbackMixin() into it.

    Partial-Bug: #1381071
    Change-Id: I81f8930cf665ccd89c03f0bd2199ce5d1d9dff65

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136106

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/136106
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=67c4c6d809e4c9e112d9fb848b5bdce9d5cd04ac
Submitter: Jenkins
Branch: master

commit 67c4c6d809e4c9e112d9fb848b5bdce9d5cd04ac
Author: Romil Gupta <email address hidden>
Date: Thu Nov 20 11:32:07 2014 -0800

    Stale VXLAN and GRE tunnel port/flow deletion

    Description:
    Stale GRE and VXLAN tunnel endpoints persists in neutron db this should be
    deleted from the database. Also, if local_ip of L2 agent changes the
    stale tunnel ports and flows persists on br-tun on other Compute Nodes and
    Network Nodes for that remote ip this should also be removed.

    Implementation

    Plugin changes:
    The plugin side changes are covered in following patch-set
    https://review.openstack.org/#/c/121000/.

    Agent changes:
    Added tunnel_delete rpc for removing stale ports and flows from br-tun.
    tunnel_sync rpc signature upgrade to obtain 'host'.
    Added testcases for TunnelRpcCallbackMixin().

    This patch-set agent deals with agent side changes.

    Closes-Bug: #1179223
    Closes-Bug: #1381071
    Closes-Bug: #1276629

    Co-Authored-By: Aman Kumar <email address hidden>
    Co-Authored-By: phanipawan <email address hidden>

    Change-Id: I291992ffde5c3ab7152f0d7462deca2e4ac1ba3f

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.