Swift replicator service fails on ubuntu due with upstart error

[Vladimir Kuklin]

{"build_id": "2014-10-14_00-01-06", "ostf_sha": "1795445bcd30ae26111e760b284078e5688f322f", "build_number": "13", "auth_required": true, "api": "1.0", "nailgun_sha": "2418864708ce1f0c6d3ebe3a27620a934d7a591a", "production": "docker", "fuelmain_sha": "c50f4d4963ee08cf85055b8ea6cc5ac575f6c1d0", "astute_sha": "c440db0449f3fe6ce6007b514e9133d8f6d0c750", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.1.1-6.0": {"VERSION": {"build_id": "2014-10-14_00-01-06", "ostf_sha": "1795445bcd30ae26111e760b284078e5688f322f", "build_number": "13", "api": "1.0", "nailgun_sha": "2418864708ce1f0c6d3ebe3a27620a934d7a591a", "production": "docker", "fuelmain_sha": "c50f4d4963ee08cf85055b8ea6cc5ac575f6c1d0", "astute_sha": "c440db0449f3fe6ce6007b514e9133d8f6d0c750", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "acee8045330cb58e49a5dd96160d7d7c56112cf3"}}}, "fuellib_sha": "acee8045330cb58e49a5dd96160d7d7c56112cf3"}]

  (/Stage[main]/Swift::Storage::Account/Swift::Storage::Generic[account]/Service[swift-account-replicator]) Could not restart Service[swift-account-replicator]: Execution of '/sbin/restart swift-account-replicator' returned 1:

It looks like we have legacy code for service management for ubuntu upstart:

  exec { "swift-init-kill-${name}-replicator" :
    command => "/usr/bin/swift-init kill ${name}-replicator",
  }

   service { "swift-${name}-replicator":
     name => $service_name,

   }

   Package["swift-${name}"] ~> Service["swift-${name}-replicator"]
  Exec["swift-init-kill-${name}-replicator"] ~> Service["swift-${name}-replicator"]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128240

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128240
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=c9b51b1a840d40b1c1543059a93d2b729050c2e7
Submitter: Jenkins
Branch: master

commit c9b51b1a840d40b1c1543059a93d2b729050c2e7
Author: Vladimir Kuklin <email address hidden>
Date: Tue Oct 14 15:05:24 2014 +0400

    Do not kill swift replicator services

    To move from exec to SysV provider of the service
    in previous releases we had to kill swift replicator
    service with swift-init kill command.

    This is not what we need in 6.0 release as we
    are already managing everything with default OS
    providers. Moreover, this commit is error-prone
    for Ubuntu with upstart provider.

    Change-Id: I9ed3a030b4987f919a9f9ec2d9351f0b2c3623b0
    Closes-bug: #1381018

[Anastasia Palkina (apalkina)]

Verified on ISO #56

"build_id": "2014-12-18_01-32-01", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "56", "auth_required": true, "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "45caacadb878abfbd9d60e134d72229698b469c9", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-18_01-32-01", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "56", "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "45caacadb878abfbd9d60e134d72229698b469c9", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "73332192a257ea02c40a39885c502ad1ebdf3eda"}}}, "fuellib_sha": "73332192a257ea02c40a39885c502ad1ebdf3eda"

Using results from http://172.18.66.221:8080/view/6.0_swarm/job/6.0_fuelmain.system_test.ubuntu.thread_4/