OS::Nova::Server throws error for unrelated OS::Neutron::Subnet

[Randall Burt]

If a template contains an OS::Neutron::Subnet and a OS::Nova::Server with no networks defined, OS::Nova::Server throws an exception because it still tries to iterate over its (non-existent) networks looking for a match with the subnet.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128146

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128146
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e0551487313e738eb83e586b32f44e0ddd7b8899
Submitter: Jenkins
Branch: master

commit e0551487313e738eb83e586b32f44e0ddd7b8899
Author: Randall Burt <email address hidden>
Date: Tue Oct 14 11:40:25 2014 -0500

    Do not match subnets if no networks defined

    Server will now skip looking for subnets on shared networks
    if the server doesn't have any networks defined. Added tests
    to verify existing behavior as well as to guard regression.

    Change-Id: I81bc3bf753843f521ccb8a96b9a40a6f82ca8d92
    Closes-Bug: #1380846