eqlx_cli_max_retries needs helptext update

Bug #1380686 reported by OpenStack Infra
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Sean McGinnis

Bug Description

https://review.openstack.org/123391
commit dafe048f2f36d221242036c159271d7544ad39e3
Author: <email address hidden> <email address hidden>
Date: Tue Sep 23 16:18:50 2014 +0800

    check the configuration eqlx_cli_max_retries

    we need to to check the value of the configuration item eqlx_cli_max_retries
    in the code in order to ensure the "eqlx_cli_max_retries" is equal to or
    greater than 0

    DocImpact: The 'retries' is not a configured number of attempts
    Change-Id: If9fadda83a855b4bbda6129d3b3a64d296eb2b54
    Closes-Bug: #1372454

Revision history for this message
Tom Fifield (fifieldt) wrote :

@Cinder Triage.

This came in via DocImpact.

The helptext in the definition for eqlx_cli_max_retries should have been updated in this patch.

Please fix this, and try and look out for this kind of stuff in reviews in the future :)

Configuration options in docs and their helptext are pulled automatically from the code - we no longer manually update.

Changed in openstack-manuals:
milestone: none → kilo
no longer affects: openstack-manuals
summary: - check the configuration eqlx_cli_max_retries
+ eqlx_cli_max_retries
summary: - eqlx_cli_max_retries
+ eqlx_cli_max_retries needs helptext update
Changed in cinder:
status: New → Confirmed
importance: Undecided → Low
Tom Fifield (fifieldt)
tags: added: low-hanging-fruit
tags: added: documentation
removed: cinder
Changed in cinder:
assignee: nobody → j_king (james-agentultra)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144656

Changed in cinder:
status: Confirmed → In Progress
Mike Perez (thingee)
Changed in cinder:
status: In Progress → Confirmed
assignee: j_king (james-agentultra) → nobody
tags: added: dell drivers
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/144656
Reason: inactive for a month

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/153245

Changed in cinder:
assignee: nobody → Sean McGinnis (sean-mcginnis)
status: Confirmed → In Progress
Mike Perez (thingee)
Changed in cinder:
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/153245
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f2b20281e64258f1e551cf90217af7444ba3db4e
Submitter: Jenkins
Branch: master

commit f2b20281e64258f1e551cf90217af7444ba3db4e
Author: Sean McGinnis <email address hidden>
Date: Thu Feb 5 08:59:22 2015 -0600

    Update eqlx driver help text

    Adds a more descriptive help text to the allowed and default values.

    Continuation of work started by James King in:
    https://review.openstack.org/#/c/144656

    Change-Id: I95de8c93bf6a6ff318d6e726488ebae371ee55bf
    Closes-Bug: 1380686

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.