Fix for adopt glance.store library in Glance

Bug #1380552 reported by Ankit Agrawal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Ankit Agrawal
Juno
Fix Released
Medium
Ankit Agrawal

Bug Description

The store module is removed from glance project and new glance_store module is created, but the glance project code was not updated properly for the required changes.

There are few cases in v1 api which needs to be addressed:

1. _get_from_store method raises store.NotFound exception from glance_store but it is still trying to catch exception.NotFound exception in glance and the actual exception has not been caught which causes 500 HTTPInternalServerError.

2. _get_size method raises store.NotFound exception from glance_store but it is still trying to catch exception.NotFound exception in glance and the actual exception has not been caught which causes 500 HTTPInternalServerError.

Tags: ntt
Changed in glance:
assignee: nobody → Ankit Agrawal (ankitagrawal)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127990

Changed in glance:
status: New → In Progress
tags: added: juno-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/128028

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Ankit Agrawal (<email address hidden>) on branch: master
Review: https://review.openstack.org/128028
Reason: Abandon, want to propose for Juno branch but by mistake proposed in master.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (proposed/juno)

Fix proposed to branch: proposed/juno
Review: https://review.openstack.org/128035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/127990
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=675a39a74faad5f7fe4eb94e1dcf7f4359ed2285
Submitter: Jenkins
Branch: master

commit 675a39a74faad5f7fe4eb94e1dcf7f4359ed2285
Author: ankitagrawal <email address hidden>
Date: Mon Oct 13 07:56:53 2014 -0700

    Fix for adopt glance.store library in Glance

    The store module is removed from glance project and new glance_store
    module is created, but the glance project code was not updated
    properly for the required changes.

    _get_from_store and _get_size methods raises store.NotFound exception
    from glance_store but not caught in the glance api.

    Updated exception.NotFound to store.NotFound which returns 404 NotFound
    response to the user.

    Closes-Bug: #1380552
    Change-Id: I068cb90f5db62443115157a027fbdefec9bd4a00

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (proposed/juno)

Change abandoned by Thierry Carrez (<email address hidden>) on branch: proposed/juno
Review: https://review.openstack.org/128035
Reason: 2014.2 released

Thierry Carrez (ttx)
tags: added: juno-backport-potential
removed: juno-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/132969

Alan Pevec (apevec)
tags: removed: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/juno)

Reviewed: https://review.openstack.org/132969
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=22b1992dc40b6c3755434b6a7ee5861688674c2f
Submitter: Jenkins
Branch: stable/juno

commit 22b1992dc40b6c3755434b6a7ee5861688674c2f
Author: ankitagrawal <email address hidden>
Date: Mon Oct 13 07:56:53 2014 -0700

    Fix for adopt glance.store library in Glance

    The store module is removed from glance project and new glance_store
    module is created, but the glance project code was not updated
    properly for the required changes.

    _get_from_store and _get_size methods raises store.NotFound exception
    from glance_store but not caught in the glance api.

    Updated exception.NotFound to store.NotFound which returns 404 NotFound
    response to the user.

    Closes-Bug: #1380552
    Change-Id: I068cb90f5db62443115157a027fbdefec9bd4a00
    (cherry picked from commit 675a39a74faad5f7fe4eb94e1dcf7f4359ed2285)

Louis Taylor (kragniz)
Changed in glance:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.