Deere needs finishing

Bug #1380138 reported by Michael S.
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Invalid
Critical
RJ Skerry-Ryan

Bug Description

The skin deer is not working. I would say there are missing files for this skin in the setup.

To be shure, i renamed the skin folder and the i started the setup again. Not better. To present what i mean, i made a screenhot and atteched it.

Revision history for this message
Michael S. (arbeit-u) wrote :
Revision history for this message
Michael S. (arbeit-u) wrote :

Sorry, information needed: W7/64 with mixxx-master-git4716-x64.exe

Revision history for this message
Daniel Schürmann (daschuer) wrote :

you see the Deere Skeleton skin. It just should looks like that.
It is a pending work, looking for contributors, to port the all Mixxx 1.11 Skins to 1.12.

Changed in mixxx:
status: New → Invalid
Revision history for this message
Owen Williams (ywwg) wrote :

I don't see the knobs or sliders, so I think maybe there are some assets missing?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Where the sliders available before the folder rename?

Changed in mixxx:
status: Invalid → New
Revision history for this message
Michael S. (arbeit-u) wrote :

The Slider wasn't seen before. That was the reaseon why i renamed the folder (fresh install skins was my goal with rename).
(I have all old folders and 1.11 files from before 1.12)
I think: At install all files must be installed. Old or new should not intrested. It should be complete installed with the newest Files.

Revision history for this message
Michael S. (arbeit-u) wrote :

When i change the skin to deer, there are many Errors to find in Mixxx Debug Messages. Messages are attached.

Revision history for this message
Michael S. (arbeit-u) wrote :

I have made a look in mixxx 1.11 skins. There in a old Deer folder. Inside 458 Files. In the new Deer are only 65 Files. (includes subfolder). Hmmm... its too less files i think.

Revision history for this message
Michael S. (arbeit-u) wrote :

I have installed the 4720 and the i copy the install details in editor. Inside i searched the skin "deer" installation part. Here is it. I say, pictures are missing.

Output folder: C:\Program Files\Mixxx\skins\Deere
Extract: beatloop.xml
Extract: beatloop_button.xml
Extract: btn_spinny1.png
Extract: btn_spinny1_over.png
Extract: btn_spinny2.png
Extract: btn_spinny2_over.png
Extract: deck_controls_row.xml
Extract: deck_inner_column.xml
Extract: deck_left.xml
Extract: deck_mixer_controls_col1.xml
Extract: deck_mixer_controls_col2.xml
Extract: deck_overview_row.xml
Extract: deck_right.xml
Extract: deck_text_row.xml
Extract: deck_visual_row.xml
Extract: effect_chain.xml
Extract: effect_chain_group_control_button.xml
Extract: effect_chain_simple.xml
Extract: effect_parameter_knob.xml
Extract: effect_rack.xml
Extract: effect_selector_buttons.xml
Extract: handle-horizontal.svg
Extract: handle-vertical.svg
Extract: hide_show_button.xml
Extract: hotcue.xml
Extract: hotcue_button.xml
Extract: knob.svg
Extract: knob.xml
Extract: knob_small.svg
Extract: left_1state_button.xml
Extract: left_deck_mixer_controls.xml
Extract: left_display_2state_button.xml
Extract: left_gutter.xml
Extract: left_right_1state_button.xml
Extract: left_right_2state_button.xml
Extract: left_right_display_2state_button.xml
Extract: library.xml
Extract: loop.xml
Extract: main_decks.xml
Extract: microphone.xml
Extract: microphone_talkover_button.xml
Extract: mixer.xml
Extract: mixer_status_bar.xml
Extract: right_deck_mixer_controls.xml
Extract: right_gutter.xml
Extract: sample_decks.xml
Extract: sampler.xml
Extract: sampler_simple.xml
Extract: sampler_text_row.xml
Extract: sampler_visual_row.xml
Extract: skin.xml
Extract: slider-horizontal.svg
Extract: slider-vertical.svg
Extract: spacer.xml
Extract: style.qss
Extract: tool_bar.xml
Extract: transport.xml
Extract: vinyl_spinny1_background.png
Extract: vinyl_spinny1_foreground.png
Extract: vinyl_spinny1_foreground_ghost.png
Extract: vinyl_spinny2_background.png
Extract: vinyl_spinny2_foreground.png
Extract: vinyl_spinny2_foreground_ghost.png
Extract: vumeter.svg
Extract: vumeter.xml
Output folder: C:\Program Files\Mixxx\skins\LateNight

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hi Michael, thanks for your investigations. Skins in 1.12.0 require far fewer files. What you're seeing (bright ugly colors and unpolished widgets) is the current state of Deere. I can confirm that there are no missing files.

Revision history for this message
Michael S. (arbeit-u) wrote :

OK, thanks for the information.
If i saw deer first time, wondering was first reaction and second searching an error ;-).

When deer is so correct, then close this bug.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Ok, we'll leave this open (even though it's an obvious one :) )

Mixxx 1.12.0 can't release until Deere is a usable skin.

summary: - Skin Deer not work
+ Deere needs finishing
Changed in mixxx:
milestone: none → 1.12.0
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
Owen Williams (ywwg) wrote :

Who wants to step up and take ownership of this? We really need this skin complete to do a release

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I'm poking at this -- others should feel free to join in.

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
jus (jus) wrote :

<quote>I'm poking at this -- others should feel free to join in.</quote>
Where do you plan to commit to? in developer_skins (Deere is out of sxnc there), directly in Master or a personal branch with a WIP PR. I have some small changes to Deere sitting here that may apply.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Direct to master was my plan. I don't have any outstanding work currently.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Mixxx 1.12.0 will not release without Deere looking awesome -- obviously :).

Closing since this doesn't describe any specific action.

Changed in mixxx:
status: Confirmed → Invalid
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7603

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.