defaults in [clients] section of configuration not applied when [clients_xxx] sections do not exist

Bug #1379958 reported by Miguel Grinberg
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Miguel Grinberg
Juno
Fix Released
Undecided
Unassigned

Bug Description

If I want to set a default endpoint_type for all my clients I can include the following in heat.conf:

[clients]
endpoint_type = internalURL

And the expected behavior is that when heat looks for a client specific section (such as [clients_glance]) and doesn't find it, it goes and grabs the property from [clients].

This unfortunately does not work, because when the configuration options are registered heat registers a copy of the [clients] default values into all the [client_xxx] sections, so even though these sections are missing in my config file, they are not missing in the configuration object, and get registered with the default value for endpoint_type before parsing heat.conf, which is publicURL.

Changed in heat:
assignee: nobody → Miguel Grinberg (miguelgrinberg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127699

Changed in heat:
status: New → In Progress
Changed in heat:
assignee: Miguel Grinberg (miguelgrinberg) → Ethan Lynn (ethanlynn)
Changed in heat:
assignee: Ethan Lynn (ethanlynn) → Miguel Grinberg (miguelgrinberg)
Steven Hardy (shardy)
Changed in heat:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/135197

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/127699
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4fd5087499b0f3dae16b183eba825e642efb0e95
Submitter: Jenkins
Branch: master

commit 4fd5087499b0f3dae16b183eba825e642efb0e95
Author: Miguel Grinberg <email address hidden>
Date: Fri Oct 10 16:02:41 2014 -0700

    unconfigured clients look in the [clients] section for defaults

    This change enables clients that have no specific settings in
    the [clients_xxx] sections of the configuration file to get defaults
    from the [clients] section.

    Change-Id: I071bd77a2e1f0ad366b80c095917a8debc5cef2b
    Closes-Bug: 1379958

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/135197
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=9f2d2095591a60d55573a788306bc26ffa76ecb1
Submitter: Jenkins
Branch: stable/juno

commit 9f2d2095591a60d55573a788306bc26ffa76ecb1
Author: Miguel Grinberg <email address hidden>
Date: Fri Oct 10 16:02:41 2014 -0700

    unconfigured clients look in the [clients] section for defaults

    This change enables clients that have no specific settings in
    the [clients_xxx] sections of the configuration file to get defaults
    from the [clients] section.

    Change-Id: I071bd77a2e1f0ad366b80c095917a8debc5cef2b
    Closes-Bug: 1379958
    (cherry picked from commit 4fd5087499b0f3dae16b183eba825e642efb0e95)

tags: added: in-stable-juno
Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.