Consider removing transaction in claim_static_ip_addresses().

[Jason Hobbs]

It's not clear to me that this transaction needs to be here since claim_static_ip_addresses() doesn't allocate IP addresses across multiple interfaces. This needs to be looked at some more when there is more time.

[Gavin Panella (allenap)]

The use of transaction.atomic() in there is under the assumption that we're already within a transaction. It should only be creating a savepoint on entry, and rolling back to it if there's an exception on exit. Django defines this behaviour when using atomic() within a transaction, iirc.

Also, claim_static_ip_addresses() *does* allocate addresses for multiple interfaces. Using a savepoint here means we get all-or-nothing behaviour.

[Jason Hobbs (jason-hobbs)]

It doesn't allocate addresses for multiple interfaces anymore - I just landed a branch that references this bug as an XXX.