Duplicate reference of 'volume_types_client' in Volume base test class

[Ghanshyam Mann]

In /tempest/api/volume/base.py admin base tests class has duplicate reference for 'volume_types_client'.

https://github.com/openstack/tempest/blob/master/tempest/api/volume/base.py#L173 & L176.

This creates confusion. Test use mix of those.

Almost all volume API concrete test class create a class variable cls.client in resource_setup and assign respective client to it which override base class cls.client. Such tests cannot use cls.client for 'volume_types_client' if needed.

Admin base class's cls.client which refer to 'volume_types_client' should be removed and tests refering that should be modified to use cls.volume_types_client.

Note - Currently there is issue/failure for that but better to clean this up.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/127136

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/127136
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=1e0a9f8f643b193a7bb49401fcee747d840e7b01
Submitter: Jenkins
Branch: master

commit 1e0a9f8f643b193a7bb49401fcee747d840e7b01
Author: ghanshyam <email address hidden>
Date: Thu Oct 9 14:15:26 2014 +0900

    Fix duplicate ref of volume_types_client in vol tests

    tempest/api/volume/base.py admin base tests class has duplicate
    reference for 'volume_types_client'. Tests use mix of both.

    This patch fix this duplicate reference and modify tests accordingly

    Closes-Bug: #1379106

    Change-Id: I016d364ad792c97d1dce12ee7da225ebe0a690f6