remove double header titles

Bug #1379044 reported by Cindy Lu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Sam Betts

Bug Description

For panels with a single table (including those that don't have tabs), I think we should remove the second heading.

We don't need to say:
Instances
Instances

Images
Images

Flavors
Flavors

Tags: ux
Revision history for this message
David Lyle (david-lyle) wrote :

I fully agree. If it's not said three time, how will they know we mean it.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
David Lyle (david-lyle) wrote :

The solution may not just be removing the header, but I agree the redundancy is not desirable. So the fix needs to be more well thought out than that.

Revision history for this message
Paul Karikh (pkarikh) wrote :

I fully agree, but we should pay attention to pages with multiple tabs in the table, because on these pages titles are not always duplicated.
For example.
Volumes
Volumes | Volume Snapshots

tags: added: ux
Sam Betts (sambetts)
Changed in horizon:
assignee: nobody → Sam Betts (sambetts)
Sam Betts (sambetts)
Changed in horizon:
assignee: Sam Betts (sambetts) → nobody
Sam Betts (sambetts)
Changed in horizon:
assignee: nobody → Sam Betts (sambetts)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Cindy Lu (clu-m) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/134222
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e98f2429fa32729b6bf7be22c03d0b9baa9ebb49
Submitter: Jenkins
Branch: master

commit e98f2429fa32729b6bf7be22c03d0b9baa9ebb49
Author: Sam Betts <email address hidden>
Date: Wed Nov 12 14:38:48 2014 +0000

    Remove duplicated headings from horizon tables

    Many panels in horizon only contain a single table, in these cases the
    tables often have the same name as the panel, leading to duplicated
    headings, e.g. Instances (panel heading) then Instances (table
    heading). This patch adds an attribute the table to hide or show the
    title, since the majority of panels have this duplication this flag
    is set to hide the heading by default allowing a developer to re-enable
    it for specific cases.

    Tabbed panels also often lead to duplicated titles between the panel
    heading and the tabs themselves, that is not fixed, however how this
    patch reduces the duplication in the case of Volumes (panel name),
    Volumes (tab name) and Volumes (table name), by hiding the table
    heading.

    Change-Id: I65efa53cc881417288e5c5b29bfa7d539e97c7dd
    Closes-Bug: 1379044

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.