testing configuration values are duplicated between config file and test

Bug #1378932 reported by Amrith Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Amrith Kumar

Bug Description

The limits used here:

https://github.com/openstack/trove/blob/proposed/juno/trove/tests/api/limits.py#L32-L35

are expected to match these:

https://github.com/openstack/trove/blob/proposed/juno/etc/trove/trove.conf.test#L87-L89

and

https://github.com/openstack/trove/blob/proposed/juno/etc/trove/trove.conf.test#L93

This makes changing the limits a two part exercise. It would be good if the test were to reference the configuration values.

This was highlighted during the review at https://review.openstack.org/#/c/125611/2/trove/tests/api/limits.py,cm

Amrith Kumar (amrith)
Changed in trove:
assignee: nobody → Amrith (amrith)
Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/125611
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=a67c0ca7030362c35ea8dd183229bc73173cf60b
Submitter: Jenkins
Branch: master

commit a67c0ca7030362c35ea8dd183229bc73173cf60b
Author: Amrith Kumar <email address hidden>
Date: Thu Oct 2 08:19:38 2014 -0400

    Increase test rate limit to avoid rate limit error

    The current rate limit is 200 requests per minute. I'm getting
    consistent tox failures as the machine is exceeding this rate. The fix
    impacts only test code and adjusts the limit and a test that has a
    hard-coded reference to the old limit. Why 500 you may ask? Because
    600 worked and 450 failed consistently with the rate limit error.

    In addition, the change addresses the fact that some test
    configuration values are duplicated in the test; the change makes the
    test reference the configuration value.

    Change-Id: I4bb290d8de6253d65b7877c743bb288ee2bce536
    Closes-Bug: #1376689
    Closes-Bug: #1378932

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
importance: Undecided → Medium
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/149208

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (stable/juno)

Reviewed: https://review.openstack.org/149208
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=874ec543a2174dc60f8da4429646a830445b6f02
Submitter: Jenkins
Branch: stable/juno

commit 874ec543a2174dc60f8da4429646a830445b6f02
Author: Amrith Kumar <email address hidden>
Date: Thu Oct 2 08:19:38 2014 -0400

    Increase test rate limit to avoid rate limit error

    The current rate limit is 200 requests per minute. I'm getting
    consistent tox failures as the machine is exceeding this rate. The fix
    impacts only test code and adjusts the limit and a test that has a
    hard-coded reference to the old limit. Why 500 you may ask? Because
    600 worked and 450 failed consistently with the rate limit error.

    In addition, the change addresses the fact that some test
    configuration values are duplicated in the test; the change makes the
    test reference the configuration value.

    Change-Id: I4bb290d8de6253d65b7877c743bb288ee2bce536
    Closes-Bug: #1376689
    Closes-Bug: #1378932
    (cherry picked from commit a67c0ca7030362c35ea8dd183229bc73173cf60b)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.