testing configuration values are duplicated between config file and test
Bug #1378932 reported by
Amrith Kumar
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack DBaaS (Trove) |
Fix Released
|
Medium
|
Amrith Kumar |
Bug Description
The limits used here:
https:/
are expected to match these:
https:/
and
https:/
This makes changing the limits a two part exercise. It would be good if the test were to reference the configuration values.
This was highlighted during the review at https:/
Changed in trove: | |
assignee: | nobody → Amrith (amrith) |
Changed in trove: | |
status: | New → In Progress |
Changed in trove: | |
importance: | Undecided → Medium |
milestone: | none → kilo-1 |
Changed in trove: | |
status: | Fix Committed → Fix Released |
Changed in trove: | |
milestone: | kilo-1 → 2015.1.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/125611 /git.openstack. org/cgit/ openstack/ trove/commit/ ?id=a67c0ca7030 362c35ea8dd1832 29bc73173cf60b
Committed: https:/
Submitter: Jenkins
Branch: master
commit a67c0ca7030362c 35ea8dd183229bc 73173cf60b
Author: Amrith Kumar <email address hidden>
Date: Thu Oct 2 08:19:38 2014 -0400
Increase test rate limit to avoid rate limit error
The current rate limit is 200 requests per minute. I'm getting
consistent tox failures as the machine is exceeding this rate. The fix
impacts only test code and adjusts the limit and a test that has a
hard-coded reference to the old limit. Why 500 you may ask? Because
600 worked and 450 failed consistently with the rate limit error.
In addition, the change addresses the fact that some test
configuration values are duplicated in the test; the change makes the
test reference the configuration value.
Change-Id: I4bb290d8de6253 d65b7877c743bb2 88ee2bce536
Closes-Bug: #1376689
Closes-Bug: #1378932