CMakeLists.txt for translations omits new plugins

Bug #1378734 reported by Jiri Grönroos
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Files
Fix Released
Medium
Cody Garver

Bug Description

http://bazaar.launchpad.net/~elementary-apps/pantheon-files/trunk/view/head:/po/CMakeLists.txt

This file doesn't include all the needed files, such as

http://bazaar.launchpad.net/~elementary-apps/pantheon-files/trunk/view/head:/plugins/pantheon-files-trash/plugin.vala

http://bazaar.launchpad.net/~elementary-apps/pantheon-files/trunk/view/head:/plugins/network-places/plugin.vala

and therefore translatable strings aren't present in http://bazaar.launchpad.net/~elementary-apps/pantheon-files/trunk/view/head:/po/pantheon-files.pot (rev 1605)

The result (part of the UI is in English) can be seen in attached screenshot.

ProblemType: Bug
DistroRelease: elementary OS 0.3
Package: pantheon-files 0.1.5.1+r1607+pkg35~ubuntu0.3.1 [origin: LP-PPA-elementary-os-daily]
ProcVersionSignature: Ubuntu 3.13.0-36.63-generic 3.13.11.6
Uname: Linux 3.13.0-36-generic x86_64
ApportVersion: 2.14.1-0ubuntu3.5
Architecture: amd64
CrashDB: pantheon_files
CurrentDesktop: Pantheon
Date: Wed Oct 8 12:53:11 2014
GsettingsChanges:

InstallationDate: Installed on 2014-08-11 (57 days ago)
InstallationMedia: elementary OS 0.3 "Freya" - Daily amd64 (20140810)
SourcePackage: pantheon-files
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Revision history for this message
Jiri Grönroos (jiri-gronroos) wrote :
Cody Garver (codygarver)
Changed in pantheon-files:
importance: Undecided → Medium
milestone: none → freya-beta2
status: New → Confirmed
Revision history for this message
Cody Garver (codygarver) wrote :

Jiri, thank you for reporting this issue.

Do you confirm the missing strings were added here?:

http://bazaar.launchpad.net/~codygarver/pantheon-files/fix-1378734/revision/1614

Changed in pantheon-files:
assignee: nobody → Cody Garver (codygarver)
status: Confirmed → In Progress
summary: - CMakeLists.txt for translations is missing translatable files
+ CMakeLists.txt for translations omits new plugins
Cody Garver (codygarver)
Changed in pantheon-files:
status: In Progress → Fix Committed
Revision history for this message
Jiri Grönroos (jiri-gronroos) wrote :

@codygarver, it's almost there. Your commit included line

../plugins/network-plugins

but it should be

../plugins/network-places

Revision history for this message
Cody Garver (codygarver) wrote :

Thanks again, Jiri, it's been corrected it

Revision history for this message
Jiri Grönroos (jiri-gronroos) wrote :

Seems to be fixed. Thanks, Cody.

Changed in pantheon-files:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in pantheon-files:
milestone: freya-beta2 → 0.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.