behind_desk method missing from action::hold_request CDBI class

Bug #1378575 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.5
Fix Released
Undecided
Unassigned
2.6
Fix Released
Undecided
Unassigned

Bug Description

When the behind_desk column was added to action.hold_request, it wasn't added to the CDBI class as well. As a consequence, when using a recent enough version of OpenSRF that doesn't supply AUTOLOAD, targeting holds can fail with the following error:

2014-10-07 17:15:11 node5.grp1.v26.sequoia.esilibrary.com open-ils.storage [ERR :30662:action.pm:1857:] Processing of hold failed: Can't locate object method "behind_desk" via package "action::hold_request" at /usr/local/share/perl/5.14.2/OpenILS/Appli...

Evergreen master
Evergreen 2.6
Evergreen 2.5

Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available in the user/gmcharlt/lp1378575_teach_cdbi_behind_desk branch of the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1378575_teach_cdbi_behind_desk

Changed in evergreen:
milestone: none → 2.next
tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Picked to master and backported to rel_2_7, rel_2_6, rel_2_5. Thanks Galen.

Changed in evergreen:
milestone: 2.next → 2.7.1
no longer affects: evergreen/2.7
Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.