Crash by using mqtt and websocket connection with same ID

[Eduard Neufeld]

mosquitto 1.4 broker crash by connecting on it with one mqtt client eg. mosquitto_sub and one websocket client eg. hivemq online client, both clients must have same id. Mosquitto wil try to reuse old connection (read_handle_server.c) but can't do it clearly becouse of diferent connections websocket and mqtt.

[Roger Light (roger.light)]

Thanks for reporting this.

The reusing of connections should work, the problem is that the old client is being freed twice. It's a tricky area, I'm going to look at changing the way it works to simplify it.

[Eduard Neufeld (edu-neufeld)]

yes, i fixed it as folow.
i dont clean context if old connection was an wsi.

[Roger Light (roger.light)]

I think this is now fixed in the latest 1.4 branch. If you could confirm it works for you I'd appreciate it.

Thanks,

Roger