Ironic should also validate the power interface before trying to start a deployment

[Lucas Alvares Gomes]

So do_node_deploy() only validates the deploy interface prior to start a deployment in Ironic[1]. We also should validate the power interface there, because powering the node on/off is part of the deployment.

It's important to note that this bug *does not* affect nodes deployed with the nova driver, since the nova driver does validate those interfaces before triggering the deployement of the node[2]

A detailed log with comments here: http://paste.openstack.org/show/119328/

[1] https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L516-L522
[2] https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L621-L631

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/126523

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/126523
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ae2f9699e00f4c3ff97ba271a91412e48f9e757f
Submitter: Jenkins
Branch: master

commit ae2f9699e00f4c3ff97ba271a91412e48f9e757f
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Oct 7 12:24:26 2014 +0100

    Validate the power interface before deployment

    This patch makes the do_node_deploy() validate the drivers power interface
    before start deploying a node because powering the node on/off is part
    of the deployment.

    Change-Id: Ic52c49ac6c8631f81eb50b69a5bdb56a113a72b4
    Closes-Bug: #1378301