IPv6 unit tests should have "ipv6" rather "v6"

Bug #1378187 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Low
Unassigned

Bug Description

At now some plugins do not have IPv6 support and keyword "v6" is checked to skip IPv6 unit tests in these plugins.
"v6" is too short and may be used in a different context.
It is better to have more clear keyword like "ipv6" in IPv6 related unit tests.

https://review.openstack.org/#/c/126407/3/neutron/tests/unit/opencontrail/test_contrail_plugin.py

Anna (annaphilips)
Changed in neutron:
assignee: nobody → Anna (annaphilips)
assignee: Anna (annaphilips) → nobody
Hao Chen (chenh1987)
Changed in neutron:
assignee: nobody → Hao Chen (chenh1987)
Hao Chen (chenh1987)
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127067

Hao Chen (chenh1987)
Changed in neutron:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/127067
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/150596

Changed in neutron:
assignee: Hao Chen (chenh1987) → Nir Magnezi (nmagnezi)
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

@Akihiro, could you please show another context for using 'v6' other than ipv6? I doubt we need a change here at all, please justify.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Nir Magnezi (<email address hidden>) on branch: master
Review: https://review.openstack.org/150596
Reason: I was hoping that Akihiro Motoki (who filed the bug) will replay to Ihar's question. it has been a while now and indeed there's not point for this at the moment.

Nir Magnezi (nmagnezi)
Changed in neutron:
assignee: Nir Magnezi (nmagnezi) → nobody
Changed in neutron:
assignee: nobody → Victor Howard (victor-r-howard)
Changed in neutron:
assignee: Victor Howard (victor-r-howard) → nobody
Changed in neutron:
status: In Progress → Incomplete
Revision history for this message
Ema (menari2) wrote :

I am new to OpenStack and interested in working on this bug, if you don't mind, as part of my application process for the Outreachy program. Thanks.

Changed in neutron:
assignee: nobody → Ema (menari2)
Revision history for this message
Reedip (reedip-banerjee-deactivatedaccount) wrote :

Hi Ema,
The bug is marked as incomplete, means it is missing some information.
As per the review comments on the bug, the importance of its merge is low.
I would suggest you discuss this with @Cedric Brandily or @Akihiro Motoki before proceeding(probably on the IRC)

Revision history for this message
Ema (menari2) wrote :

Thanks Reedip. I have also checked with Akihiro Motoki and it makes sense for me to drop this bug. I have picked up another bug- hopefully that one will be available for me to work on.

Changed in neutron:
assignee: Ema (menari2) → nobody
Revision history for this message
Akihiro Motoki (amotoki) wrote :

When this bug was filed, there are various plugins in the neutron main tree.
Now vendor decomposition are almost completed and the need to address this bug significantly decreased (and almost there is no need).
I would like to make this bug "Won't Fix".

Changed in neutron:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.