[library] Puppet Heat uses 2 templates

Bug #1378032 reported by Sergii Golovatiuk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Denis Egorenko
7.0.x
Won't Fix
Low
Fuel Library (Deprecated)

Bug Description

Heat uses own templates for CentOS and Ubuntu. It's better to merge into one.

Tags: area-mos
Changed in fuel:
importance: Undecided → Low
status: New → In Progress
assignee: nobody → Sergii Golovatiuk (sgolovatiuk)
milestone: none → 6.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/126364

Changed in fuel:
milestone: 6.0 → 6.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/126364

Changed in fuel:
status: In Progress → Won't Fix
Revision history for this message
Sergii Golovatiuk (sgolovatiuk) wrote :

OCF scrips were moved packages. Without ERB it will require some logic to determine OS based on /etc/issue.net. The concept how we start heat should be redesigned based on pacemaker

Changed in fuel:
assignee: Sergii Golovatiuk (sgolovatiuk) → Fuel Library Team (fuel-library)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → MOS Puppet Team (mos-puppet)
milestone: 6.1 → 8.0
status: Won't Fix → Confirmed
no longer affects: fuel/8.0.x
Dmitry Pyzhov (dpyzhov)
tags: added: area-mos
Revision history for this message
Ivan Berezovskiy (iberezovskiy) wrote :

Now templates are:
1. https://github.com/openstack/fuel-library/blob/master/files/fuel-ha-utils/ocf/heat_engine_centos
2. https://github.com/openstack/fuel-library/blob/master/files/fuel-ha-utils/ocf/heat_engine_ubuntu

They have small difference:
diff heat_engine_centos heat_engine_ubuntu
200a201
> ocf_log debug "Create pid file dir: ${PID_DIR} and chown to ${OCF_RESKEY_user}"
258c259
< . /etc/rc.d/init.d/functions
---
> . /lib/lsb/init-functions
260c261
< daemon --user "${OCF_RESKEY_user}" --pidfile "${OCF_RESKEY_pid}" "${OCF_RESKEY_binary} --config-file ${OCF_RESKEY_config} --logfile ${LOG} &>/dev/null & echo \$! > ${OCF_RESKEY_pid}"
---
> start-stop-daemon --start --background --quiet --chuid "${OCF_RESKEY_user}:${OCF_RESKEY_user}" --make-pidfile --pidfile "${OCF_RESKEY_pid}" --startas "${OCF_RESKEY_binary}"

Changed in fuel:
status: Confirmed → Triaged
Changed in fuel:
assignee: MOS Puppet Team (mos-puppet) → Ivan Berezovskiy (iberezovskiy)
Changed in fuel:
assignee: Ivan Berezovskiy (iberezovskiy) → Denis Egorenko (degorenko)
Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/255176

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/255176
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f2326bb68b1985ec8c1454c1447d35f12f1c321f
Submitter: Jenkins
Branch: master

commit f2326bb68b1985ec8c1454c1447d35f12f1c321f
Author: Denis Egorenko <email address hidden>
Date: Wed Dec 9 13:00:01 2015 +0300

    Combine Heat-engine OCF scripts for Ubuntu & Centos into one common

    Currently we have two ocf scripts for Heat-engine: for ubuntu and
    centos. This patch removes this separation and combines into
    one common OCF script.

    Change-Id: I5e440f50da20ef26fca22a34df98864925f8211e
    Closes-bug: #1378032

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Timur Nurlygayanov (tnurlygayanov) wrote :

Deployment of Heat works fine on MOS 8.0, moved to verified.

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.