[DOC] Manual for pt-query-digest --type binlog is ambiguous
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Frank Cizmich |
Bug Description
The manual suggests that the pt-query-digest is able to parse a raw binary log file, while it can only parse a file which was decoded with mysqlbinlog tool before.
http://
Moreover, the tool does not write any errors when we try to parse raw binlog:
pt-query-digest --type binlog master/
# 290ms user time, 10ms system time, 33.70M rss, 228.73M vsz
# Current date: Mon Oct 6 13:17:59 2014
# Hostname: pmlap
# Files: master/
# Overall: 0 total, 1 unique, 0 QPS, 0x concurrency _______
# Time range: unknown
# Attribute total min max avg 95% stddev median
# ============ ======= ======= ======= ======= ======= ======= =======
# Query size 1.12k 1.12k 1.12k 1.12k 1.12k 0 1.12k
# Profile
# Rank Query ID Response time Calls R/Call V/M Item
# =========== =========== =========== =========== =========== ===== ======
In PTDEBUG=1 we can see:
# Pipeline:11527 28350 Pipeline process BinaryLogParser
\
# BinaryLogParser
# BinaryLogParser
# BinaryLogParser
# 'pos_in_log',
# 0,
# 'cmd',
# 'Query',
# 'ts',
# undef,
# 'arg',
#
#
# �
-
(F��O��s2T
(uF
�e�v2T
(-F
# 'bytes',
# 1147
# ];
No clear errors though.
Related branches
- Daniel Nichter: Needs Fixing
-
Diff: 99 lines (+45/-3)2 files modifiedbin/pt-query-digest (+24/-2)
t/pt-query-digest/binlog_analyses.t (+21/-1)
Changed in percona-toolkit: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Frank Cizmich (frank-cizmich) |
milestone: | none → 2.2.12 |
Changed in percona-toolkit: | |
status: | Triaged → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → In Progress |
tags: | added: i46467 |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
Changed the docs, and now the tool also checks if the file is binary, providing a relevant error message.