Fuel for OpenStack

[ui] [settings] Save Changes button doesn't work properly on Settings tab

Bug #1377870 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Julia Aranovich
Fuel for OpenStack 6.1

Bug Description

Steps to reproduce:
1. load Settings tab with default values
2. hange some setting to display a dependent toggleable setting group
3. change some setting in this group
4. hide the group

Expexted result: Save Settings button is locked.
Actual result: Save Settings button is available cause it takes into account changes in hidden settings too.

Tags: ui
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: none → 6.0
Julia Aranovich (jkirnosova)
summary: - [ui] Save Changes button doesn't work properly on Settings tab
+ [ui] [settings] Save Changes button doesn't work properly on Settings
+ tab
Julia Aranovich (jkirnosova)
Changed in fuel:
assignee: Julia Aranovich (jkirnosova) → Fuel UI Team (fuel-ui)
Vitaly Kramskikh (vkramskikh)
Changed in fuel:
milestone: 6.0 → 6.1
Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

Is it fixed now? We've refactored settings model.

Revision history for this message
Alexandra Morozova (astepanchuk) wrote :

Still reproducable. Example - check VMWare vCenter/ESXi datastore for images (Glance), fill in all field and then uncheck it

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/140294

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Julia Aranovich (jkirnosova)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/140294
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=ae6083e467aef9caf26e6e72429a3e654e2f5530
Submitter: Jenkins
Branch: master

commit ae6083e467aef9caf26e6e72429a3e654e2f5530
Author: Julia Aranovich <email address hidden>
Date: Tue Dec 9 12:43:13 2014 +0300

    Adds restriction check to settings changes detection algorithm

    Closes-Bug: #1377870
    Closes-Bug: #1389671

    Change-Id: Ifa6e9f7ea3292c8176c3d277285fd46a9b5693bd

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on ISO #58

"build_id": "2015-01-13_21-50-03", "ostf_sha": "0c1b663c6fc02ad972f2ed9ff6b000e7be1ea207", "build_number": "58", "auth_required": true, "api": "1.0", "nailgun_sha": "6fa6147384b533fb3d56cdc49ec6ecbcca47675d", "production": "docker", "fuelmain_sha": "", "astute_sha": "82125b0eef4e5a758fd4afa8917812e09a1f7dac", "feature_groups": ["mirantis"], "release": "6.1", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2015-01-13_21-50-03", "ostf_sha": "0c1b663c6fc02ad972f2ed9ff6b000e7be1ea207", "build_number": "58", "api": "1.0", "nailgun_sha": "6fa6147384b533fb3d56cdc49ec6ecbcca47675d", "production": "docker", "fuelmain_sha": "", "astute_sha": "82125b0eef4e5a758fd4afa8917812e09a1f7dac", "feature_groups": ["mirantis"], "release": "6.1", "fuellib_sha": "c53cb3a2bd5f99f32f78ed18e9472724fa6a9a9e"}}}, "fuellib_sha": "c53cb3a2bd5f99f32f78ed18e9472724fa6a9a9e"

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.