Suggestion: Add Okular to cleaners

Bug #1377708 reported by Mark Brandis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BleachBit
Fix Released
Medium
Andrew Ziem

Bug Description

Please add Okular to the cleaner list. See attached cleaner xml.

Tags: okular
Revision history for this message
Mark Brandis (mark-brandis) wrote :
Revision history for this message
Andrew Ziem (ahziem1) wrote :

Thank you for the file, Mark.

I merged it with the existing cleaner in the CleanerML repository
https://github.com/az0/cleanerml/commit/0f024583ee1a3138a459192b7d445dfc80953410

Please review.

Also, in the future it is preferable to submit cleaners as pull requests here https://github.com/az0/cleanerml

Changed in bleachbit:
assignee: nobody → Andrew Ziem (ahziem1)
milestone: none → 1.6
status: New → In Progress
Revision history for this message
Andrew Ziem (ahziem1) wrote :

Have you had a chance to review the changes, Mark?

Changed in bleachbit:
milestone: 1.6 → 1.8
Revision history for this message
Mark Brandis (mark-brandis) wrote :

Doesn't work as intended:

- .kde path missing (only .kde4 for "Document meta data" and "Recent documents list")
- bleachbit shows error if filename from walk.files from "Document meta data" has non-ascii characters.

Delete 0 /home/mad/.kde/share/apps/okular/bookmarks.xml.tbcache
Exception while running operation 'okular': ''ascii' codec can't encode character u'\xe4' in position 58: ordinal not in range(128)'
Delete 4.1kB /home/mad/.adobe/Flash_Player/AssetCache/XXXXXXXXX

Revision history for this message
Andrew Ziem (ahziem1) wrote :

for .kde path missing, do you mean this is the solution?

<option id="docdata">
    <label>Document meta data</label>
    <description>Includes name, location, and page placement of previously opened documents</description>
    <action command="delete" search="walk.files" path="~/.kde/share/apps/okular/docdata/"/> <!-- changed -->
    <action command="delete" search="walk.files" path="~/.kde4/share/apps/okular/docdata/"/>
  </option>
  <option id="recent_documents">
    <label>Recent documents list</label>
    <description>Delete the list of recently used documents</description>
    <action search="file" path="~/.kde/share/config/okularrc" command="ini" section="Recent Files"/> <!-- changed -->
    <action search="file" path="~/.kde4/share/config/okularrc" command="ini" section="Recent Files"/>
  </option>

Changed in bleachbit:
milestone: 1.8 → 1.10
Andrew Ziem (ahziem1)
Changed in bleachbit:
milestone: 1.10 → 1.12
Changed in bleachbit:
importance: Undecided → Medium
Revision history for this message
Andrew Ziem (ahziem1) wrote :

Fixed in git commit 5c500ab

Changed in bleachbit:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.