Resource leakage in api/messaging/test_queues

Bug #1377031 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Low
Ghanshyam Mann

Bug Description

There can be resource leakage during test - tempest.tempest.api.messaging.test_queues -> test_delete_queue.

This tests does pop 1 element from shared list (self.queues which is being used by other tests as well as in resource cleanup) and then delete request is done.

In case where delete request fails then it cause other tests to fail and resource leakage as element has been removed from self.queues even before actual deletion.

This should delete the element from self.queues once delete operation is successful.

Changed in tempest:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/125901

Changed in tempest:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/125901
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=e0befa487d99da7e7b79b0488ffac6a86e055ac0
Submitter: Jenkins
Branch: master

commit e0befa487d99da7e7b79b0488ffac6a86e055ac0
Author: ghanshyam <email address hidden>
Date: Fri Oct 3 16:12:08 2014 +0900

    Fix resource leakage in messaging.test_queues

    Test messaging.test_queues.test_delete_queue does pop 1 element from
    shared list (self.queues which is being used by other tests as well
    as in resource cleanup) and then delete request is done.

    In case where delete request fails then it cause other tests to fail
    and resource leakage as element has been removed from self.queues
    even before actual deletion.

    Individual test should not be side-effecting mutable class variables
    that are used by other tests. So merging delete tests with create tests.

    Closes-Bug: #1377031

    Change-Id: If24a903160e716a685d7121e0968881542f072fc

Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.