No way to prevent duplicates in endpoints

Bug #1376937 reported by Vish Ishaya
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Won't Fix
Medium
Unassigned

Bug Description

Keystone doesn't provide a way to ensure that we do not create duplicate endpoints. Imagine two concurrent workers attempting to create a keystone endpoint. There are no unique constraints for endpoints besides the id, but the id cannot be set externally, so there isn't an easy way to ensure only one gets created without a global lock

Tags: validation
Revision history for this message
David Stanek (dstanek) wrote :

What would you expect the unique constraint to be based on? I could see url, url/enabled, and a few other combinations.

Changed in keystone:
status: New → Confirmed
Revision history for this message
Dolph Mathews (dolph) wrote :

I would suggest pretty much everything except enabled: service_id + region_id + interface + url

Would that work, Vish?

Changed in keystone:
importance: Undecided → Medium
Revision history for this message
Raildo Mascena de Sousa Filho (raildo) wrote :

I will follow the @dolph suggestion. ok?

Changed in keystone:
assignee: nobody → Raildo Mascena de Sousa Filho (raildo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134095

Changed in keystone:
status: Confirmed → In Progress
Changed in keystone:
assignee: Raildo Mascena de Sousa Filho (raildo) → Henrique Truta (henriquetruta)
Changed in keystone:
assignee: Henrique Truta (henriquetruta) → Raildo Mascena de Sousa Filho (raildo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/241748

Changed in keystone:
assignee: Raildo Mascena de Sousa Filho (raildo) → Henrique Truta (henriquetruta)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Henrique Truta (<email address hidden>) on branch: master
Review: https://review.openstack.org/241748
Reason: This change won't be necessary anymore, since the URL column won't be included in the Unique constraint

Changed in keystone:
assignee: Henrique Truta (henriquetruta) → Raildo Mascena de Sousa Filho (raildo)
tags: added: validation
Changed in keystone:
milestone: none → mitaka-3
Changed in keystone:
milestone: mitaka-3 → mitaka-rc1
Changed in keystone:
assignee: Raildo Mascena de Sousa Filho (raildo) → David Stanek (dstanek)
Revision history for this message
Steve Martinelli (stevemar) wrote :

bumping this from mitaka-rc1, as the patch that fixes it is WIP. this bug is not a blocker, we've lived with it for a few releases now.

Changed in keystone:
milestone: mitaka-rc1 → none
Revision history for this message
Steve Martinelli (stevemar) wrote :

Automatically unassigning due to inactivity.

Changed in keystone:
assignee: David Stanek (dstanek) → nobody
status: In Progress → Triaged
Revision history for this message
Steve Martinelli (stevemar) wrote :

This would break backwards compatibility.

Changed in keystone:
status: Triaged → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by David Stanek (<email address hidden>) on branch: master
Review: https://review.openstack.org/134095
Reason: The bug is marked as won't fix

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.