thumbnails in metadata generated incorrectly

[Bill Filler]

build 76 rtm-proposed on krillin

Take a picture with camera-app
swipe to the right to display it
it looks squashed and like it's being displayed at the wrong aspect ratio
open the gallery-app and view the photo and it looks equally bad
share the photo to messaging-app, and the preview of the photo is black
copy the photo to your desktop and open there and the photo looks fine

these are all new regressions, not sure what layer it's in bug guessing a low layer as gallery, camera and messaging-app have not changed in this regard

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

FWIW I have seen black preview in messaging app back on saturday, so that's been there a few days/images.

[Bill Filler (bfiller)]

apparently qtubuntu-camera was updated to take photos at higher res and could be causing the issue:
see https://code.launchpad.net/~phablet-team/qtubuntu-camera/trunk rev 114

image size taken by camera is now 2448 x 4352 not sure what is was previously

[Brendan Donegan (brendan-donegan)]

The black square in messaging-app is actually this bug: https://bugs.launchpad.net/ubuntu/+source/messaging-app/+bug/1373462

This regression came well after the resolution increase so that isn't the only reason (although it may be part of it).

[Brendan Donegan (brendan-donegan)]

This started happening in image #75 which saw a thumbnailer landing - I installed #74 and upgraded only the thumbnailer binary packages and indeed it can be reproduced that way.

[Jussi Pakkanen (jpakkane)]

This is a bug in the camera app. It produces jpg files whose exif thumbnails have incorrect aspect ratio. Attached is a raw thumbnail extracted from a jpg produced with the camera.

Thumbnailer uses the embedded exif image if it exists (this is the change mentioned above) because scaling the full image is way too slow and resource hungry.

[Bill Filler (bfiller)]

@jussi
Please, please, please:
next time you attempt to land changes to libthumbnailer, please thoroughly run the camera-app and gallery-app test plans!! This should have been caught during testing and the landings could have been coordinated rather than introducing this nasty regression.

camera-app uses qtubuntu-camera, so moving the bug to that project.

[Bill Filler (bfiller)]

The code in qtubuntu-camera or underlying hybris/Android code needs to be fixed to correctly set the aspect ratio on the exif thumbnail that is embedded in the jpeg.

[Jussi Pakkanen (jpakkane)]

There is a MR to temporarily disable exif thumbnails here:

https://code.launchpad.net/~jpakkane/thumbnailer/aspectworkaround/+merge/236925

[Brendan Donegan (brendan-donegan)]

If you're doing the fix in thumbnailer the task can't be invalid.

[Jim Hodapp (jhodapp)]

This was most likely caused by this change: http://bazaar.launchpad.net/~phablet-team/qtubuntu-camera/trunk/revision/114

[Florian Boucault (fboucault)]

EXIF thumbnail generation is done by Android. There is a set of API to get/set the desired size of the thumbnail and also to retrieve the list of possible thumbnail sizes:

http://developer.android.com/reference/android/hardware/Camera.Parameters.html#getSupportedJpegThumbnailSizes()

However there is no guarantee that a thumbnail size with the same aspect ratio as the pictures is going to always be available. That said, the solution would be to add logic in qtubuntu-camera to use the APIs above to select the appropriate thumbnail size. For that to happen these APIs need to be exposed in libhybris first.

[Olli Ries (ories)]

this bug needs to be targeted after RTM, via ota

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Timo Jyrinki (timo-jyrinki)]

This was reportedly fixed via http://launchpadlibrarian.net/191646180/thumbnailer_1.3%2B14.10.20141020-0ubuntu1_1.3%2B15.04.20141106~rtm-0ubuntu1.diff.gz + http://launchpadlibrarian.net/192809040/qtubuntu-camera_0.3.3%2B14.10.20141001-0ubuntu1_0.3.3%2B15.04.20141208.is.0.3.3%2B15.04.20141204~rtm-0ubuntu1.diff.gz

The changelogs for these were wrong, but this is what they looked in the archive uploads: https://lists.canonical.com/archives/rtm-14.09-changes/2014-December/000960.html + https://lists.canonical.com/archives/rtm-14.09-changes/2014-December/000961.html

QA is now reporting a possible regression.

[Timo Jyrinki (timo-jyrinki)]

Filed bug #1403906

[Pat McGowan (pat-mcgowan)]

Marking fixed per comments