trove client HTTPClient __init__ fails if auth_url None

Bug #1375982 reported by William C. Arnold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-troveclient
In Progress
Medium
William C. Arnold

Bug Description

I see the same problem in the python-troveclient source that is in the python-cinderclient.

Specifically, in troveclient/client.py (also troveclient/compat/client.py):
        self.auth_url = auth_url.rstrip('/')
should be (like in some other clients, e.g. nova and neutron)
       self.auth_url = auth_url.rstrip('/') if auth_url else auth_url

The code without a None check is a problem when an auth tokem is requested from a trust; e.g. this can happen in openstack heat for nested stacks of stacks.

Revision history for this message
William C. Arnold (barnold-8) wrote :
Changed in python-troveclient:
assignee: nobody → William C. Arnold (barnold-8)
Denis M. (dmakogon)
Changed in python-troveclient:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/125195

Changed in python-troveclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-troveclient (master)

Change abandoned by William C. Arnold (<email address hidden>) on branch: master
Review: https://review.openstack.org/125195
Reason: Doing diffs against other clients, it is clear that more work is required.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.