upgrade_packages broken in zypper/openSUSE

[Aleš Křivák]

Given the following setting in user data:

#cloud-config
package_upgrade: true

cloud-init will fail to upgrade packages on openSUSE (and probably SLES) distro.
The reason for this is that cloud-init calls cloud.distro.package_command("upgrade") to upgrade packages, where the given argument is passed directly to zypper. But unlike apt-get on Debian-based systems, zypper uses command update to upgrade packages.

I am including simple patch to sles.py, which will modify argument in package_command, but it would be probably better to add new function (e. g. upgrade_packages) and call this in cc_package_update_upgrade_install.py instead of package_command("upgrade").

[Joshua Powers (powersj)]

Hi! thanks for taking the time to not only file a bug but also include a patch to resolve the issue! I apologize that no one got to your bug till now. I wanted to let you know that a revamp of the sles/opensuse code was recently merged here:

https://github.com/cloud-init/cloud-init/commit/cbda576a7bbf846710ad55940bf8ca1f2d2194b9

I am going to mark this fix committed. If you have any further questions or follow ups please feel free to respond in this bug! Thanks!

[Scott Moser (smoser)]

This should be fixed in 17.1, based on Josh's url.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/2487