Rabbit OCF: we should idempotently block / unblock
Bug #1375824 reported by
Bogdan Dobrelya
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Committed
|
Medium
|
Bogdan Dobrelya | ||
5.1.x |
Fix Committed
|
Medium
|
Bogdan Dobrelya | ||
6.0.x |
Fix Committed
|
Medium
|
Bogdan Dobrelya |
Bug Description
Related bug: https:/
We should idempotent add/remove blocking rules to iptables. If we have it already for some reason, we should skip the action, otherwise under some conditions we'll have more than one rule left.
Changed in fuel: | |
status: | New → Triaged |
importance: | Undecided → Medium |
milestone: | none → 6.0 |
assignee: | nobody → Fuel Library Team (fuel-library) |
tags: | added: ha pacemaker rabbitmq |
Changed in fuel: | |
status: | Triaged → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/124121 /git.openstack. org/cgit/ stackforge/ fuel-library/ commit/ ?id=f390f336683 250ebd2cf41110e dab33f4ed5ef80
Committed: https:/
Submitter: Jenkins
Branch: master
commit f390f336683250e bd2cf41110edab3 3f4ed5ef80
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Sep 25 20:55:43 2014 +0300
Fix blocking reject rule for rabbit ocf
* Make RMQ unblock call safe (remove all discovered RMQ
blocking rules, if there are many of them).
* Use unblock safe call prior to the blocking one.
* Make block call idempotent and add 5 retries for iptables.
* Add info log messages about block/unblock actions. Notify
if RMQ blocking rule cannot be added for some strange reason.
Partial-bug: #1373569
Closes-bug: #1375824
Change-Id: I46c6bf3c83ada4 273eaa05530e808 86ebac7e75f
Signed-off-by: Bogdan Dobrelya <email address hidden>