Cinder should not publish sensitive data such as user token in notifications.

Bug #1375599 reported by Ajaya Agrawal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Undecided
Unassigned
OpenStack Security Advisory
Won't Fix
Undecided
Unassigned

Bug Description

Here is a message captured in rabbitmq:

ctxt: {u'domain': None, u'project_name': u'admin', u'user_id': u'f6fafd3282a841849a01beeb80fd3161', u'roles': [u'heat_stack_owner', u'_member_', u'admin'], u'user_identity': u'f6fafd3282a841849a01beeb80fd3161 d6acdbfa2bba426c912f214c665e78d9 - - -', u'project_domain': None, u'timestamp': u'2014-09-25T07:01:02.936829', u'auth_token': u'bac7c01f4eb1412b841ab819ceddc5ad', u'remote_address': u'19.0.0.99', u'quota_class': None, u'project_id': u'd6acdbfa2bba426c912f214c665e78d9', u'is_admin': True, u'user': u'f6fafd3282a841849a01beeb80fd3161', u'service_catalog': [{u'endpoints': [{u'adminURL': u'http://19.0.0.99:8774/v2/d6acdbfa2bba426c912f214c665e78d9', u'region': u'RegionOne', u'internalURL': u'http://19.0.0.99:8774/v2/d6acdbfa2bba426c912f214c665e78d9', u'publicURL': u'http://19.0.0.99:8774/v2/d6acdbfa2bba426c912f214c665e78d9'}], u'type': u'compute', u'name': u'nova'}], u'request_id': u'req-623ecb62-0660-4264-b0d3-04eb13f54914', u'user_domain': None, u'read_deleted': u'no', u'tenant': u'd6acdbfa2bba426c912f214c665e78d9'}
publisher_id: volume.aj-celiometer@lvmdriver-1
event_type: volume.delete.end
payload: {u'status': u'deleting', u'instance_uuid': None, u'user_id': u'f6fafd3282a841849a01beeb80fd3161', u'availability_zone': u'nova', u'tenant_id': u'd6acdbfa2bba426c912f214c665e78d9', u'created_at': u'2014-09-24 14:11:42', u'snapshot_id': None, u'volume_type': u'0bc2a44a-fd19-4448-8399-1538fc8724e5', u'host': u'aj-celiometer@lvmdriver-1#lvmdriver-1', u'replication_status': u'disabled', u'volume_id': u'25102eee-9e82-4ba8-8f8c-17bc52c6519f', u'replication_extended_status': None, u'replication_driver_data': None, u'size': 1, u'launched_at': u'2014-09-24 14:11:42', u'display_name': None}
metadata: {'timestamp': u'2014-09-25 07:01:19.271715', 'message_id': u'9c77a382-05c2-4014-a1a9-cbc41b2d2eb7'}

Tags: security
Ajaya Agrawal (ajayaa)
information type: Private Security → Public
Revision history for this message
Jeremy Stanley (fungi) wrote :

Does this pose a risk of leaking credentials across privilege boundaries? If so, we'll want to discuss the potential for issuing a security advisory.

Changed in ossa:
status: New → Incomplete
information type: Public → Public Security
Revision history for this message
Ajaya Agrawal (ajayaa) wrote :

Hi Jeremy,

It doesn't leak as of now. But if someone get access to messaging infrastructure, then he can potentially intercept all the user data and would be able compromise their accounts by simply changing password. Or worse by getting an admin token he can potentially paralyze the whole infrastructure.

I don't see a use of user token in any component which would be consuming notifications.

Revision history for this message
Jeremy Stanley (fungi) wrote :

Thanks Ajaya. In that case I think we should probably tag this "security" to indicate it's a good opportunity for security hardening, but not issue an advisory when it's fixed and (likely) not worry about getting it backported to previous releases.

Jeremy Stanley (fungi)
tags: added: security
Changed in ossa:
status: Incomplete → Won't Fix
information type: Public Security → Public
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote : Bug Cleanup

Closing stale bug. If this is still an issue please reopen.

Changed in cinder:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.