Code cleanup: get rid of "using namespace"
Bug #1375579 reported by
GunChleoc
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
According to the Google Style Guide, "using namespace foo" is not a good idea:
http://
You may not use a using-directive to make all names from a namespace available.
// Forbidden -- This pollutes the namespace.
using namespace foo;
You may use a using-declaration anywhere in a .cc file, and in functions, methods or classes in .h files.
Related branches
lp:~widelands-dev/widelands/bug-1375579
- SirVer: Approve
-
Diff: 106 lines (+40/-6)4 files modifiedcmake/codecheck/rules/no_using_namespace_in_header_files (+32/-0)
src/graphic/gl/system_headers.h (+1/-0)
src/wui/building_statistics_menu.cc (+2/-0)
src/wui/building_statistics_menu.h (+5/-6)
| tags: | added: cleanups lowhangingfruit |
| description: | updated |
| Changed in widelands: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → GunChleoc (gunchleoc) |
| milestone: | none → build19-rc1 |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| Changed in widelands: | |
| assignee: | GunChleoc (gunchleoc) → nobody |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
To post a comment you must log in.
Fixed in build19-rc1.