swap_volume does not save changes made in _connect_volume

[Thang Pham]

This is a bug reported by Nikola in a review - https://review.openstack.org/#/c/121965/8/nova/virt/libvirt/driver.py.

swap_volume does not save changes for connection_info. In swap_volume, a call is made to _connect_volume, which modifies connection_info. For example, in the LibvirtISCSIVolumeDriver, connection_info['data']['host_device'] = host_device. However, this update is not saved to the DB, such that any updates made within swap_volume are lost. We need to save any changes made in _connect_volume to the DB, as it is done elsewhere in the code, e.g. _get_guest_storage_config https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3488.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/125208

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/125208
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=beae8b764c48fcb3f6bfb245f75be04e428e1942
Submitter: Jenkins
Branch: master

commit beae8b764c48fcb3f6bfb245f75be04e428e1942
Author: Thang Pham <email address hidden>
Date: Tue Sep 30 15:14:29 2014 -0400

    Save bdm in swap_volume

    swap_volume does not save bdm changes for connection_info. In
    swap_volume, a call is made to _connect_volume that modifies
    connection_info. For example, in the LibvirtISCSIVolumeDriver,
    connection_info['data']['host_device'] = host_device. However,
    this update is not saved to the DB, such that any updates made
    within swap_volume are lost. Changes made in _connect_volume
    need to be saved to the DB.

    Change-Id: I19d5182d11097c4796093d77b5b7de11b7bc7bd8
    Closes-Bug: #1375531