The headers needed to use features shown in the acceptance tests are not published
Bug #1375301 reported by
Alan Griffiths
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Alan Griffiths | ||
mir (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
mir (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The acceptance tests validate the features provided for user code.
For user code to use these features the corresponding headers must be published.
Related branches
lp:~alan-griffiths/mir/fix-1375301
- Daniel van Vugt: Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
- Cemil Azizoglu (community): Abstain
- Kevin DuBois (community): Approve
- Alexandros Frantzis (community): Approve
-
Diff: 1245 lines (+600/-473)12 files modifiedinclude/server/mir/compositor/scene_element.h (+1/-1)
tests/CMakeLists.txt (+0/-3)
tests/acceptance-tests/CMakeLists.txt (+0/-2)
tests/acceptance-tests/test_client_library.cpp (+0/-2)
tests/acceptance-tests/test_client_surface_swap_buffers.cpp (+85/-0)
tests/acceptance-tests/test_server_shutdown.cpp (+0/-409)
tests/integration-tests/CMakeLists.txt (+9/-1)
tests/integration-tests/test_client_surface_swap_buffers.cpp (+55/-55)
tests/integration-tests/test_server_shutdown.cpp (+434/-0)
tests/mir_test_doubles/CMakeLists.txt (+5/-0)
tests/mir_test_framework/CMakeLists.txt (+4/-0)
tests/unit-tests/CMakeLists.txt (+7/-0)
summary: |
- The headers needed to use features show in the acceptance tests are not + The headers needed to use features shown in the acceptance tests are not published |
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir: | |
status: | New → Opinion |
Changed in mir: | |
status: | New → Confirmed |
tags: | added: regression |
Changed in mir: | |
importance: | Undecided → Low |
status: | Confirmed → In Progress |
milestone: | none → 0.8.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir (Ubuntu): | |
status: | Fix Released → Invalid |
tags: | removed: regression |
To post a comment you must log in.
By definition, acceptance tests should validate the functionality we expose to developers using the server and client libraries. Like the code in examples/, they also act as examples/ documentation of correct usage and expected behavior of our offered APIs. Also, like the code in examples/, it doesn't make sense to showcase the API and then not make it available to developers (see previous discussion at https:/ /code.launchpad .net/~vanvugt/ mir/privatise- underused- headers/ +merge/ 232865).
This bug is a matter of opinion only to the degree that the definition of the acceptance tests is a matter of opinion (I think it's not). It's a another matter altogether whether this bug should be fixed at the moment or not, for which there are indeed different opinions.