conductor should call validate before send_sensor_data

Bug #1375103 reported by Anusha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Sam Betts

Bug Description

_send_sensor_data in manager.py missed to call validate before initiating driver specific call
calling validate enables conductor to validate the driver specific information and also maintains consistency with other functions in manager.py.

Tags: conductor
Dmitry Tantsur (divius)
summary: - _send_sensor_data fails to call validate in conductor
+ conductor should call validate before send_sensor_data
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
tags: added: conductor
Sam Betts (sambetts)
Changed in ironic:
assignee: nobody → Sam Betts (sambetts)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/125387

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/125387
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d8aec8c766444f56f741dfb6a53a1b6f1a2de69e
Submitter: Jenkins
Branch: master

commit d8aec8c766444f56f741dfb6a53a1b6f1a2de69e
Author: Sam Betts <email address hidden>
Date: Wed Oct 1 16:19:14 2014 +0100

    Add a call to management.validate(task)

    Makes sure _send_sensor_data calls the driver validate method before
    calling get_sensor_data.

    Change-Id: I859ff3d315765f463a433fe3c02cb975f98972d2
    Closes-Bug: 1375103

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.