client log incorrectly contains "Shell Commands no in allow list"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Xibo |
Fix Released
|
Undecided
|
Dan Garner |
Bug Description
Windows 7, 32-bit
XiboClient 1.5.0 (as reported by the Client Options "About" button)
In Client Options, Advanced tab, place a check in the tickbox Enable Shell Commands, and type the desired program's name in the Shell Command Allow List.
In a region in a layout, place a shell command media and specify the name of the program that is in the shell command allow list.
Schedule that layout. After it has been shown, check the XiboLog.txt file. Notice there is an entry "Error: <message>Shell Commands not in allow list:" etc.
This entry exists in the log even though the shell command was successfully executed. (incorrect behaviour)
This entry does not exist if the shell command allow list is left empty. (correct behaviour)
This entry exists if you attempt to execute a command not in the allow list. (correct behaviour - so it's not a security problem, just a logging problem.)
Related branches
- Xibo Maintainters: Pending requested
-
Diff: 1291 lines (+337/-382)20 files modifiedclient/dotNET/Forms/OptionForm.cs (+1/-1)
client/dotNET/Log/ClientInfo.Designer.cs (+33/-27)
client/dotNET/Log/ClientInfo.cs (+8/-2)
client/dotNET/Log/ClientInfo.resx (+21/-18)
client/dotNET/Log/StatLog.cs (+63/-125)
client/dotNET/Logic/ApplicationSettings.cs (+2/-2)
client/dotNET/Logic/RequiredFiles.cs (+3/-3)
client/dotNET/Logic/ScheduleManager.cs (+41/-33)
client/dotNET/Logic/ScreenShot.cs (+1/-0)
client/dotNET/Media/CefWebMedia.cs (+69/-40)
client/dotNET/Media/IeWebMedia.cs (+70/-41)
client/dotNET/Media/ShellCommand.cs (+5/-1)
client/dotNET/Media/TemporaryFile.cs (+0/-71)
client/dotNET/Web References/xmds/Reference.cs (+10/-8)
client/dotNET/Web References/xmds/Reference.map (+1/-1)
client/dotNET/Web References/xmds/xmds.wsdl (+4/-3)
client/dotNET/XiboClient.csproj (+2/-3)
client/dotNET/XmdsAgents/FileAgent.cs (+1/-1)
client/dotNET/XmdsAgents/RegisterAgent.cs (+1/-1)
client/dotNET/default.config.xml (+1/-1)
Changed in xibo: | |
assignee: | nobody → Dan Garner (dangarner) |
milestone: | none → 1.7.0-alpha2 |
tags: | added: dotnetclient |
Changed in xibo: | |
status: | New → Fix Committed |
Changed in xibo: | |
status: | Fix Committed → Fix Released |