FFe: Sync websocket-client 0.18.0-1 (universe) from Debian unstable (main), juju-deployer 0.4.2, python-jujuclient 0.18.4

[James Page]

Please sync websocket-client 0.18.0-1 (universe) from Debian unstable (main)

Explanation of the Ubuntu delta and why it can be dropped:

  * d/p/skip-internet-tests: skip tests which require Internet access.

Now upstream; the Breaks/Replaces was only required for 14.04 so can also be dropped.

Explanation of FeatureFreeze exception:

We'd like to introduce new versions of juju-deployer and python-jujuclient, to enable SSL support for accessing Juju environments, which depend on features in 0.18.0 of websocket.

Changelog entries since current utopic version 0.12.0-1ubuntu2:

websocket-client (0.18.0-1) unstable; urgency=medium

  * Team upload.
  * New upstream version.

 -- Barry Warsaw <email address hidden> Thu, 25 Sep 2014 09:40:28 -0400

websocket-client (0.16.0a-2) unstable; urgency=medium

  * Team upload.
  * Add python3-websocket binary package. (Closes: #749943)
  * d/control: wrap-and-sort

 -- Barry Warsaw <email address hidden> Wed, 20 Aug 2014 17:01:51 -0400

websocket-client (0.16.0a-1) unstable; urgency=medium

  * New upstream release
    - Include the test-suite and run it at build-time (Closes: #741606, #744726)
  * Switch buildsystem to pybuild
  * Update copyright file
  * Do not ship the tests module in the binary

 -- Nicolas Dandrimont <email address hidden> Fri, 15 Aug 2014 23:51:19 +0200

[James Page (james-page)]

juju-deployer:

New upstream release fixes bug 1288685, includes misc other fixes and a couple of minor new features (taken from review of bzr changelog).

python-jujuclient:

New upstream release enables SSL cert checking functionality requiring websocket-client >= 0.18 + misc other fixes.

[James Page (james-page)]

All proposed updates and test-rebuilds in :

https://launchpad.net/~james-page/+archive/ubuntu/utopic

[Robie Basak (racb)]

juju-quickstart also needs python-websocket >= 0.18 and python-jujuclient >= 0.18.4 in bug 1359938 and bug 1359944.

[Robie Basak (racb)]

From #juju on Freenode:

11:04 <frankban> rbasak: I think we need to bump the version of the dependencies. unfortunately the expected topic version of websocket-client includes backward incompatible changes, so we needed to reflect those changes

[...]

11:17 <frankban> rbasak: the public API of websocket client did not change a lot, IIRC it's mostly a change in how wss certs are handled by default

I think we need to take some care with the other two reverse depends - python-socketio-client and python-docker. I don't know if they would be impacted or not.

[Kapil Thangavelu (hazmat)]

there are no backwards incompatible changes from 0.16 to 0.18. there was one from 0.12 to 0.14 but 0.16 is already in debian and utopic. The fix from 0.16 to 0.18 is to support bypassing hostname verification (ssl.match_hostname) which is broken with ip addresses in python. ie. the full changelog from 0.16 to 0.18 is.

v0.18.0
allow override of match_hostname usage on ssl (#105)
v0.17.0
can't set timeout on a standing websocket connection (#102)
fixed local variable 'error' referenced before assignment (#102, #98)

per rdepends of python-websocket, i've manually verified this with the utopic version of docker-py its successfully passes its unit and functional tests with 0.18. The other rdepend is python-socketio-client which has bit-rotted unit tests and is broken independently and upstream for its core functionality with the socket.io 1.0 spec (see https://github.com/invisibleroads/socketIO-client/issues/52). That said it also has no issues with the 0.18 websocket client.

[Logan Rosen (logan)]

This bug was fixed in the package websocket-client - 0.18.0-2
Sponsored for James Page (james-page)

---------------
websocket-client (0.18.0-2) unstable; urgency=medium

  * Team upload.
  * Do not ship tests module in python3-websocket binary package either
    (Closes: #767400)
    - Thanks to Teemu Hukkanen for the patch

 -- Scott Kitterman <email address hidden> Fri, 14 Nov 2014 00:50:57 -0500

websocket-client (0.18.0-1) unstable; urgency=medium

  * Team upload.
  * New upstream version.

 -- Barry Warsaw <email address hidden> Thu, 25 Sep 2014 09:40:28 -0400

websocket-client (0.16.0a-2) unstable; urgency=medium

  * Team upload.
  * Add python3-websocket binary package. (Closes: #749943)
  * d/control: wrap-and-sort

 -- Barry Warsaw <email address hidden> Wed, 20 Aug 2014 17:01:51 -0400

websocket-client (0.16.0a-1) unstable; urgency=medium

  * New upstream release
    - Include the test-suite and run it at build-time (Closes: #741606, #744726)
  * Switch buildsystem to pybuild
  * Update copyright file
  * Do not ship the tests module in the binary

 -- Nicolas Dandrimont <email address hidden> Fri, 15 Aug 2014 23:51:19 +0200