HTTPBadRequest returns to the client when creating a existing default rule

[Haiwei Xu]

$ nova secgroup-add-default-rule icmp -1 -1 0.0.0.0/0

ERROR (BadRequest): This default rule already exists. (HTTP 400) (Request-ID: req-11ee577a-03f2-49c1-b033-4dd1df57ff1a)

while HTTP 409 should be returned.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124326

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138324

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138324
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=71efc3dc56f3f5cb201a0c903a706f1d4288d1e2
Submitter: Jenkins
Branch: master

commit 71efc3dc56f3f5cb201a0c903a706f1d4288d1e2
Author: abhishek.talwar <email address hidden>
Date: Tue Dec 2 17:03:33 2014 +0530

    Error code for creating secgroup default rule

    Trying to create secgroup group default rules
    that already exists gives HttpBadRequest error,
    but it should raise HttpConflict.

    So updated the code to HttpConflict error.
    Closes-Bug: #1374320

    Change-Id: I93c6eb7fb96e7109404206367ed81495a4724296

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/124326
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.