lb-vip-update: updating the vip with pool id throws internal server error

[Shweta Naik]

R1.10 build 41

Updating vip with different pool-id throws internal server error.
If this action is not supported then proper error msg should be given.

root@a5s311:/opt/contrail/utils# neutron lb-pool-list
+--------------------------------------+---------+-------------------+----------+----------------+--------+
| id | name | lb_method | protocol | admin_state_up | status |
+--------------------------------------+---------+-------------------+----------+----------------+--------+
| 9acf94ad-779d-4358-93f8-2d567c7d9978 | mypool | ROUND_ROBIN | HTTP | True | ACTIVE |
| 5a7fc178-c5bc-4560-b99f-fea7ab405d55 | sshpool | LEAST_CONNECTIONS | TCP | True | ACTIVE |
+--------------------------------------+---------+-------------------+----------+----------------+--------+

root@a5s311:/opt/contrail/utils# neutron lb-vip-show myvip
+---------------------+--------------------------------------+
| Field | Value |
+---------------------+--------------------------------------+
| address | 10.1.1.6 |
| admin_state_up | True |
| connection_limit | -1 |
| description | http-vip |
| id | ce638d72-35e3-40d2-98df-e70a22c0ff14 |
| name | myvip |
| pool_id | 9acf94ad-779d-4358-93f8-2d567c7d9978 |
| port_id | 4e10b041-9fd2-4029-9fc1-ae2f6451d60a |
| protocol | HTTP |
| protocol_port | 80 |
| session_persistence | |
| status | ACTIVE |
| subnet_id | 6a3474cf-998d-4c9d-8b87-00661b4a6397 |
| tenant_id | 6dfb22b204a84006b161a137149e7e9c |
+---------------------+--------------------------------------+

root@a5s311:/opt/contrail/utils# neutron lb-vip-update ce638d72-35e3-40d2-98df-e70a22c0ff14 --pool-id 5a7fc178-c5bc-4560-b99f-fea7ab405d55
Request Failed: internal server error while processing your request.

2014-09-25 15:32:53.866 ERROR [neutron.api.v2.resource] update failed
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/neutron/api/v2/resource.py", line 84, in resource
    result = method(request=request, **args)
  File "/usr/lib/python2.7/dist-packages/neutron/api/v2/base.py", line 486, in update
    obj = obj_updater(request.context, id, **kwargs)
  File "/usr/lib/python2.7/dist-packages/neutron_plugin_contrail/plugins/opencontrail/loadbalancer/plugin.py", line 101, in update_vip
    v = super(LoadBalancerPlugin, self).update_vip(context, id, vip)
  File "/usr/lib/python2.7/dist-packages/neutron_plugin_contrail/plugins/opencontrail/loadbalancer/loadbalancer_db.py", line 83, in update_vip
    return self._vip_manager.update(context, id, vip)
  File "/usr/lib/python2.7/dist-packages/neutron_plugin_contrail/plugins/opencontrail/loadbalancer/resource_manager.py", line 278, in update
    if self.update_object(obj, id, r):
  File "/usr/lib/python2.7/dist-packages/neutron_plugin_contrail/plugins/opencontrail/loadbalancer/virtual_ip.py", line 283, in update_object
    vip_db.set_localbalancer_pool(pool)
AttributeError: 'VirtualIp' object has no attribute 'set_localbalancer_pool'

[Rudra Rugge (rrugge)]

R1.10:
https://github.com/Juniper/contrail-neutron-plugin/commit/9d4e28b660fda09bdf9e33357c6dadfd158fe4c3

Master:
https://github.com/Juniper/contrail-neutron-plugin/commit/d9a854e9a08c6c15aee2ed95d99c65f82b7e9899