Typo in call to LibvirtConfigObject's parse_dom() method

Bug #1374158 reported by Jennifer Mulsow
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Davanum Srinivas (DIMS)

Bug Description

In Juno in nova/virt/libvirt/config.py:

LibvirtConfigGuestPUNUMA.parse_dom() calls super with a capital 'D' in parse_dom().

        super(LibvirtConfigGuestCPUNUMA, self).parse_Dom(xmldoc)

LibvirtConfigObject does not have a 'parse_Dom()' method. It has a 'parse_dom()' method. This causes the following exception to be raised.

...
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/config.py", line 1733, in parse_dom
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack obj.parse_dom(c)
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/config.py", line 542, in parse_dom
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack numa.parse_dom(child)
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/config.py", line 509, in parse_dom
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack super(LibvirtConfigGuestCPUNUMA, self).parse_Dom(xmldoc)
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstackAttributeError: 'super' object has no attribute 'parse_Dom'
2014-09-25 15:35:21.546 14344 TRACE nova.api.openstack
2014-09-25 15:35

Tags: libvirt
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124231

Changed in nova:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: Confirmed → In Progress
tags: added: libvirt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/124231
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=480a932173219bda0f7ead61fd406fe4a366832c
Submitter: Jenkins
Branch: master

commit 480a932173219bda0f7ead61fd406fe4a366832c
Author: Davanum Srinivas <email address hidden>
Date: Thu Sep 25 20:15:23 2014 -0400

    Fix Typo in method name - parse_Dom

    Silly typo

    Closes-Bug: #1374158

    Change-Id: Icccfb1a606bc9e14188d9f5c5f5667e35f2cb413

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.