Touchspots are rendered as squares
Bug #1373698 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
mir (Ubuntu) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
Touchspots are rendered as a square (containing a circle). Looks like a bug where we're not blending properly because I think they're meant to appear as circles.
Related branches
lp:~kdub/mir/fix-1373698
- Daniel van Vugt: Disapprove
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 134 lines (+47/-4)7 files modifiedinclude/platform/mir/graphics/renderable.h (+3/-0)
platform-ABI-sha1sums (+1/-1)
server-ABI-sha1sums (+1/-1)
src/server/compositor/gl_renderer.cpp (+1/-1)
src/server/input/touchspot_controller.cpp (+1/-1)
tests/unit-tests/compositor/test_gl_renderer.cpp (+24/-0)
tests/unit-tests/input/test_touchspot_controller.cpp (+16/-0)
lp:~vanvugt/mir/simplify-alpha
- Daniel van Vugt: Approve
- Kevin DuBois (community): Approve
- Alberto Aguirre (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 257 lines (+8/-41)14 files modifieddebian/changelog (+1/-0)
include/platform/mir/graphics/renderable.h (+0/-1)
platform-ABI-sha1sums (+1/-1)
playground/render_overlays.cpp (+0/-5)
server-ABI-sha1sums (+1/-1)
src/platform/graphics/android/hwc_device.cpp (+1/-1)
src/platform/graphics/android/hwc_fallback_gl_renderer.cpp (+1/-1)
src/platform/graphics/android/hwc_layerlist.cpp (+2/-2)
src/platform/symbols.map (+0/-1)
src/server/input/touchspot_controller.cpp (+0/-5)
src/server/scene/basic_surface.cpp (+0/-8)
tests/include/mir_test_doubles/fake_renderable.h (+0/-5)
tests/include/mir_test_doubles/mock_renderable.h (+0/-1)
tests/include/mir_test_doubles/stub_renderable.h (+1/-9)
Changed in mir: | |
assignee: | Robert Carr (robertcarr) → Kevin DuBois (kdub) |
Changed in mir: | |
milestone: | none → 0.8.0 |
Changed in mir: | |
assignee: | Kevin DuBois (kdub) → Daniel van Vugt (vanvugt) |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir (Ubuntu): | |
status: | Fix Released → Invalid |
To post a comment you must log in.
Let's get this fixed while it's still fresh and we haven't released it.