Conflicting power actions being dropped on the floor can result in leaving a node in an inconsistent state
Bug #1373368 reported by
Raphaël Badin
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
Graham Binns | ||
Bug Description
How to reproduce:
- Get a node to commission
- In the UI, click "Abort commissioning"
- Really quickly after this (i.e. before the node has been turned off) re-commission the node
- the power on action has been dropped on the floor (see pserv.log) but the commissioning action hasn't been canceled
=> The node is off but is commissioning.
Related branches
lp:~gmb/maas/catch-errors-in-power-callsites
- Raphaël Badin (community): Approve
- Gavin Panella (community): Approve
-
Diff: 508 lines (+368/-17)2 files modifiedsrc/maasserver/models/node.py (+76/-13)
src/maasserver/models/tests/test_node.py (+292/-4)
Revision history for this message
| Raphaël Badin (rvb) wrote | #1 |
| summary: |
- Conflicting power actions being dropped on the floor can result leaving - the nodes in an inconsistent state + Conflicting power actions being dropped on the floor can result in + leaving a node in an inconsistent state |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Graham Binns (gmb) |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
Revision history for this message
| Graham Binns (gmb) wrote | #3 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 1.7.0 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
When power actions are "abandoned" because another one is in progress, the whole encapsulating transaction should be cancelled.