ipset set couldn't not be clean when corresponding security rule is deleted

[shihanzhang]

In bellow case, if L2 agent enable ipset, ipset set couldn't be clean:

1.launch a instance with IPv4 address in default security group
2.delete the IPv4 ingress rule

the corresponding ipset set should be clean, but now it is not clean

[Oleg Bondarev (obondarev)]

By saying "should be clean" do you mean it should be deleted completely? After performing described steps I'm seeing:

$ sudo ipset list
Name: IPv4a811eae7-9594-4cfa-a
Type: hash:ip
Revision: 2
Header: family inet hashsize 1024 maxelem 65536
Size in memory: 16520
References: 0
Members:

Does it affects security groups functionality somehow or the bug is just about the garbage that should be collected?

[shihanzhang (shihanzhang)]

yes, it does not affects security groups functionality, the bug is just about the garbage

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123972

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123972
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=48fd90d55f13195cc6331e50da85bf6440f1f8f9
Submitter: Jenkins
Branch: master

commit 48fd90d55f13195cc6331e50da85bf6440f1f8f9
Author: shihanzhang <email address hidden>
Date: Thu Sep 25 16:11:29 2014 +0800

    Fix L2 agent does not remove unused ipset set

    The patch fixes L2 agent does not remove unused ipset set when security
    group contains rules for only IPv4 or IPv6.

    Change-Id: I375b1683cd763c0a33dc935558c637874d36ffa1
    Closes-bug: #1373287