when client is terminated by an keyboardInterrupt, return code should be 130

[Rakesh H S]

---------------------------------
root@devstack:/opt/stack/python-neutronclient# glance image-list
^C... terminating glance client
root@devstack:/opt/stack/python-neutronclient# echo $?
1
---------------------------------

As shown above, the return code as of now is 1.

Since the client was terminated by an KeyboardInterrupt the return code should be 130. It is useful when people are writing automation test cases and want to validate based on the return code.

As of now, some of the clients such as:
cinderclient
heatclient
ironicclient
already report correclty as 130.

proposing the same for glanceclient and novaclient.

[melanie witt (melwitt)]

Code 130 is a special code to mean "Script terminated by Control-C" so I think this makes sense.

[1] http://tldp.org/LDP/abs/html/exitcodes.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123934

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123936

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123936
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=09f97e9ee43427d101c719ec26e8cd26dcd0e39d
Submitter: Jenkins
Branch: master

commit 09f97e9ee43427d101c719ec26e8cd26dcd0e39d
Author: Rakesh H S <email address hidden>
Date: Thu Sep 25 11:31:26 2014 +0530

    return 130 for keyboard interrupt

    when keyboard interrupt is received by novaclient, the return code as
    of now is 1.

    But since the client was terminated by an keyboard interrupt, the return
    code should be 130. (http://tldp.org/LDP/abs/html/exitcodes.html)
    It is useful when people are writing automation test cases and want to
    validate based on the return code.
    I have also changed the message that is printed on shell to match other
    clients.

    Change-Id: If544ade154c53b1f18518773f4d49cd335a394d0
    Closes-Bug: #1373231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123934
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=96ff6e46c4e5c476b42399d9df016a468b2e1b6d
Submitter: Jenkins
Branch: master

commit 96ff6e46c4e5c476b42399d9df016a468b2e1b6d
Author: Rakesh H S <email address hidden>
Date: Thu Sep 25 11:19:31 2014 +0530

    Return 130 for keyboard interrupt

    When keyboard interrupt is received by glanceclient, the return code as
    of now is 1.

    But since the client was terminated by an keyboard interrupt, the return
    code should be 130. (http://tldp.org/LDP/abs/html/exitcodes.html)
    It is useful when people are writing automation test cases and want to
    validate based on the return code.

    Change-Id: Ia70116ab6f0708a0ce6eeaed07c1e7a56e68c9f4
    Closes-Bug: #1373231