redstack undoes DevStack's screen "log on" setup

[Mat Lowery]

If SCREEN_LOGDIR is set then DevStack will enable screen logging:

https://github.com/openstack-dev/devstack/blob/8fe3f70efd6c74479d2f17b789976fb3dfb8efd2/functions-common#L1240-L1241

However, trove-integration/scripts/redstack stops (by stuffing Ctrl-C then "exit" then Enter into the window) and starts (by creating a new named window). I propose that it doesn't close the original window (on stop) and re-uses the existing window (on start).

Doing Ctrl-a " shows the window list like this:

Num Name Flags

  0 shell $
  1 key $(L)
  2 key-access $(L)
  3 horizon $(L)
  4 s-proxy $(L)
  5 s-object $(L)
  6 s-container $(L)
  7 s-account $(L)
  8 g-reg $(L)
  9 g-api $(L)
 10 n-api $(L)
 11 n-cpu $(L)
 12 n-cond $(L)
 13 n-crt $(L)
 14 n-net $(L)
 15 n-sch $(L)
 16 n-cauth $(L)
 17 n-obj $(L)
 18 c-api $(L)
 19 c-sch $
 20 c-vol $(L)
 21 h-eng $(L)
 22 h-api $(L)
 23 h-api-cfn $(L)
 24 h-api-cw $
 25 tr-api $
 26 tr-tmgr $
 27 tr-cond $

And what you want to see is this:

Num Name Flags

  0 shell $
  1 key $(L)
  2 key-access $(L)
  3 horizon $(L)
  4 s-proxy $(L)
  5 s-object $(L)
  6 s-container $(L)
  7 s-account $(L)
  8 g-reg $(L)
  9 g-api $(L)
 10 n-api $(L)
 11 n-cpu $(L)
 12 n-cond $(L)
 13 n-crt $(L)
 14 n-net $(L)
 15 n-sch $(L)
 16 n-cauth $(L)
 17 n-obj $(L)
 18 c-api $(L)
 19 c-sch $(L)
 20 c-vol $(L)
 21 h-eng $(L)
 22 h-api $(L)
 23 h-api-cfn $(L)
 24 h-api-cw $
 25 tr-api $(L)
 26 tr-tmgr $(L)
 27 tr-cond $(L)

The (L) indicates that logging is on.

I realize that logs go to trove-integration/report/logs for Trove processes but having them all in the same place (SCREEN_LOGDIR) is very convenient.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123582

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123582
Committed: https://git.openstack.org/cgit/openstack/trove-integration/commit/?id=2f054b09f4d80589d004553f83e49c2193f360a5
Submitter: Jenkins
Branch: master

commit 2f054b09f4d80589d004553f83e49c2193f360a5
Author: Mat Lowery <email address hidden>
Date: Mon Sep 22 15:52:13 2014 -0500

    Reuse existing screen window when restarting Trove

    Closes-Bug: #1373121
    Change-Id: I7b50c7c0b9ab8df917afda8cf6ca83c46b352505