Fuel for OpenStack

Logic of role validation is incorrect

Bug #1373109 reported by Vitaly Kramskikh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Przemyslaw Kaminski
Fuel for OpenStack 6.0
5.1.x
Fix Committed
High
Przemyslaw Kaminski
Fuel for OpenStack 5.1.1-updates

Bug Description

The code at

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/api/v1/validators/assignment.py#L114-L127

is absolutely incorrect and must use expression parser. Role assignment now working by an accident.

Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

https://review.openstack.org/#/c/122173/7/nailgun/nailgun/fixtures/openstack.yaml - example of potential change where the old logic breaks CLI tests

Przemyslaw Kaminski (pkaminski)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Przemyslaw Kaminski (pkaminski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/125287

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/125287
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=fbaa4ee9d82a29011cc485c2ff24f99cf65c082e
Submitter: Jenkins
Branch: master

commit fbaa4ee9d82a29011cc485c2ff24f99cf65c082e
Author: Przemyslaw Kaminski <email address hidden>
Date: Wed Oct 1 10:24:43 2014 +0200

    Fix role validation using new Expression class

    Removed _search_in_settings (seems to be unused now).
    Fixed test_assignment_validator.py

    Change-Id: I3c5e8fa6c8165e0fb75f09829d98b8cad5166410
    Closes-Bug: #1373109

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (stable/5.1)

Related fix proposed to branch: stable/5.1
Review: https://review.openstack.org/130543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/5.1)

Reviewed: https://review.openstack.org/130543
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4aa4fb5f89c02aaee5bec1aa4677b48598ffe482
Submitter: Jenkins
Branch: stable/5.1

commit 4aa4fb5f89c02aaee5bec1aa4677b48598ffe482
Author: Przemyslaw Kaminski <email address hidden>
Date: Wed Oct 1 10:24:43 2014 +0200

    Fix role validation using expression_parser

    Removed _search_in_settings (seems to be unused now).
    Fixed test_assignment_validator.py

    (cherry picked from commit fbaa4ee9d82a29011cc485c2ff24f99cf65c082e)
    Closes-Bug: #1376831
    Closes-Bug: #1373109
    Change-Id: I3c5e8fa6c8165e0fb75f09829d98b8cad5166410

Revision history for this message
Przemyslaw Kaminski (pkaminski) wrote :

For 5.1 the fix is commited for this bug: https://bugs.launchpad.net/fuel/+bug/1376831

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.