Missing validation/enforcement for environment name on create/update in CLI

[Brian Tully]

Through the Murano UI, when a user creates a new environment (or updates an existing environment) we run the "name" field through a validation function that warns the user if they have any "illegal" characters other than alphanumeric characters and underscores. However the CLI does not enforce this validation which can lead to some strangely named environments that are created in the CLI that do not validate in the UI. Ultimately, this leads to a confusing user experience.

Do environment names need to be validated/enforced in the UI, and if so, shouldn't they also be validated/enforced through the muranoclient CLI (or API) in order to be consistent?

Originally filed here: https://bugs.launchpad.net/python-muranoclient/+bug/1372498

After discussion with sjmc7 and ruhe on IRC, moving to murano API.

[Brian Tully (brian-tully)]

sergmelikyan: I've actually already started on this bug but see that you assigned it to yourself. I'd like to continue working on it if you don't mind as I think it would be a good learning experience for me. Let me know.

[Serg Melikyan (smelikyan)]

Brian, no problem. I have assigned this bug to myself cause it had no assignee and it is assigned to RC-1. I would be happy if you will work on it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124177

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124177
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=a55b8427a8c328a47277cedcd287e860424221ca
Submitter: Jenkins
Branch: master

commit a55b8427a8c328a47277cedcd287e860424221ca
Author: Brian Tully <email address hidden>
Date: Thu Sep 25 16:39:54 2014 -0400

    Missing validation for environment name in API

    Add environment name validation to API so that when names are entered
    by user via the murano client CLI they get validated in the same way
    they do via the murano dashboard UI, i.e., name must contain only
    alphanumeric or "_-." characters, must start with alpha. If not valid,
    raise an exception with a 400 error.

    Change-Id: Ib125e017acbdd6b6881ec705763c17170b80e44b
    Closes-Bug: 1373045