drivers' vendor_passthru should log all exceptions

Bug #1372979 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Sam Betts

Bug Description

Since the drivers' vendor_passthru are async. calls, any exceptions raised by them won't be handled. So all exceptions, even non-Ironic exceptions should be logged.

If there is common code, maybe move it to the base class.

This is a followup to a comment in https://review.openstack.org/#/c/122224/3/ironic/drivers/modules/agent.py.

Dmitry Tantsur (divius)
Changed in ironic:
status: New → Triaged
tags: added: conductor driver
Sam Betts (sambetts)
Changed in ironic:
assignee: nobody → Sam Betts (sambetts)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129298

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/129298
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=4bfae01ed04104f56b62c2844eabe2c151742a56
Submitter: Jenkins
Branch: master

commit 4bfae01ed04104f56b62c2844eabe2c151742a56
Author: Sam Betts <email address hidden>
Date: Fri Oct 17 13:52:00 2014 +0100

    Add logging to driver vendor_passthru functions

    Since the drivers' vendor_passthru are async. calls, any exceptions
    raised by them won't be handled. So all exceptions, even non-Ironic
    exceptions should be logged.

    This patch adds a decorator that can be used to wrap passthru function
    calls and ensure that any exceptions get logged correctly, also adds
    unit tests to ensure decorators functionality.

    Change-Id: I17006611fd59d5f4dc78fdaefdf802e9fb7caff2
    Implements: blueprint extended-vendor-passthru
    Closes-Bug: 1372979

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.