Puppet manifests should not fail if user add cinder nodes to environment with Ceph RBD

[Anastasia Palkina]

"build_id": "2014-09-17_21-40-34",
"ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346",
"build_number": "11",
"auth_required": true,
"api": "1.0",
"nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d",
"production": "docker",
"fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd",
"astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13",
"feature_groups": ["mirantis"],
"release": "5.1",
"release_versions": {"2014.1.1-5.1": {"VERSION": {"build_id": "2014-09-17_21-40-34", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "11", "api": "1.0", "nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d", "production": "docker", "fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd", "astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"}}},
"fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"

I did test case:

1. Create new environment (CentOS, HA mode)
2. Choose nova-network, vlan manager
3. Choose both Ceph
4. Choose Sahara
5. Add 3 controller+ceph+cinder, 2 compute+ceph, 1 cinder
6. Configure interfaces (see screen) and untag management network
7. Start deployment. It was successful
8. But there were many errors in cinder logs and puppet log (see this bug https://bugs.launchpad.net/fuel/+bug/1352335 )

This errors appears because adding cinder nodes to an environment with Ceph RBD used as backend for volumes (instead of Cinder LVM backend) is not a valid configuration.
Puppet manifests should not failed if user did this case.

[Bartłomiej Piotrowski (bpiotrowski)]

Current roles and settings constrains make impossible to reproduce such setup. (More specifically, you can't assign controller+ceph+cinder).