instance task status keep for long time when reboot

[Eli Qiao]

When doing reboot, the task status will be REBOOT_STARTED for
long time in some cases, it's better to add this status
when polling the rebooting instances and try to trigger
reboot again.

[tagett@stack-01 devstack]$ nova list
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| bb44fafb-7a63-4c93-974f-031a9cceeaa3 | instance0 | ACTIVE | - | Running | private=192.168.1.74, 172.24.4.41 |
| 990a03e7-4487-4137-9b51-e8f20986ffcb | t2 | REBOOT | reboot_started | Running | private=192.168.1.91 |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
[tagett@stack-01 devstack]$ nova reboot t2
ERROR (Conflict): Cannot 'reboot' while instance is in task_state reboot_started (HTTP 409) (Request-ID: req-9006c602-dd74-41ef-b154-2e5e0ed53d65)
[tagett@stack-01 devstack]$ date
2014年 09月 23日 星期二 16:11:54 CST
[tagett@stack-01 devstack]$ nova list
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| bb44fafb-7a63-4c93-974f-031a9cceeaa3 | instance0 | ACTIVE | - | Running | private=192.168.1.74, 172.24.4.41 |
| 990a03e7-4487-4137-9b51-e8f20986ffcb | t2 | REBOOT | reboot_started | Running | private=192.168.1.91 |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
[tagett@stack-01 devstack]$ date
2014年 09月 23日 星期二 16:12:00 CST
[tagett@stack-01 devstack]$ nova list
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| bb44fafb-7a63-4c93-974f-031a9cceeaa3 | instance0 | ACTIVE | - | Running | private=192.168.1.74, 172.24.4.41 |
| 990a03e7-4487-4137-9b51-e8f20986ffcb | t2 | REBOOT | reboot_started | Running | private=192.168.1.91 |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
[tagett@stack-01 devstack]$ nova list
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| bb44fafb-7a63-4c93-974f-031a9cceeaa3 | instance0 | ACTIVE | - | Running | private=192.168.1.74, 172.24.4.41 |
| 990a03e7-4487-4137-9b51-e8f20986ffcb | t2 | REBOOT | reboot_started | Running | private=192.168.1.91 |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
[tagett@stack-01 devstack]$ date
2014年 09月 23日 星期二 16:12:08 CST
[tagett@stack-01 devstack]$ nova list
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| bb44fafb-7a63-4c93-974f-031a9cceeaa3 | instance0 | ACTIVE | - | Running | private=192.168.1.74, 172.24.4.41 |
| 990a03e7-4487-4137-9b51-e8f20986ffcb | t2 | REBOOT | reboot_started | Running | private=192.168.1.91 |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
[tagett@stack-01 devstack]$ nova list
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+
| bb44fafb-7a63-4c93-974f-031a9cceeaa3 | instance0 | ACTIVE | - | Running | private=192.168.1.74, 172.24.4.41 |
| 990a03e7-4487-4137-9b51-e8f20986ffcb | t2 | REBOOT | reboot_started | Running | private=192.168.1.91 |
+--------------------------------------+-----------+--------+----------------+-------------+-----------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123392

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123392
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cb42b79c1bf3a260c52087416ce46d4602bf2941
Submitter: Jenkins
Branch: master

commit cb42b79c1bf3a260c52087416ce46d4602bf2941
Author: Eli Qiao <email address hidden>
Date: Tue Sep 23 16:15:57 2014 +0800

    Add more status when do _poll_rebooting_instances

    Add task_states.REBOOT_STARTED and REBOOT_PENDING to the filters
    when doing _poll_rebooting_instances.

    When doing reboot, the task status will be REBOOT_STARTED for
    long time in some cases, it's better to add this status
    when polling the rebooting instances and try to trigger
    reboot again.
    for REBOOT_PENDING, it is also reasonable to be added.

    besides, this patch also adds new unit test case for
    _poll_rebooting_instances.

    Change-Id: I84e8cb402291ab1401d432cac8701d34a82d2d60
    Closes-Bug: 1372812