Deprecation warning breaks Node model tests
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Jeroen T. Vermeulen |
Bug Description
When I run the Node model tests in isolation, no matter how many, I get exactly one failure like:
«
FAIL: maasserver.
-------
_StringException: Traceback (most recent call last):
File "src/maasserver
self.
File "/usr/lib/
self.
File "/usr/lib/
raise mismatch_error
MismatchError: !=:
reference = u''
actual = u'src/metadatas
»
A lot of model tests check the Twisted error log, and aren't expecting to find this DeprecationWarning there. It looks as if the warning only comes once per test run, and so whatever test does this check first will fail. The others are unaffected.
Related branches
- Gavin Panella (community): Needs Information
-
Diff: 567 lines (+88/-75)15 files modifiedsrc/maasserver/api/commissioning_scripts.py (+3/-3)
src/maasserver/api/tests/test_nodegroup.py (+3/-3)
src/maasserver/forms.py (+2/-2)
src/maasserver/models/filestorage.py (+3/-3)
src/maasserver/models/tests/test_node.py (+3/-3)
src/maasserver/testing/factory.py (+4/-4)
src/maasserver/tests/test_third_party_drivers.py (+2/-2)
src/metadataserver/api.py (+4/-3)
src/metadataserver/fields.py (+25/-16)
src/metadataserver/migrations/0012_commission_result_binary_data_recode.py (+2/-3)
src/metadataserver/models/commissioningscript.py (+3/-3)
src/metadataserver/models/nodeuserdata.py (+4/-4)
src/metadataserver/models/tests/test_nodecommissionresult.py (+3/-3)
src/metadataserver/models/tests/test_noderesults.py (+2/-2)
src/metadataserver/tests/test_fields.py (+25/-21)
- Gavin Panella (community): Approve
-
Diff: 29 lines (+7/-2)1 file modifiedsrc/metadataserver/fields.py (+7/-2)
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |