valid_name, valid_branch_name constraints allow trailing newline

[Michael Hudson-Doyle]

The pattern used in valid_branch_name (r"^[a-z0-9][a-z0-9\+\.\-]*$") allows a trailing newline in the branch name:

>>> re.match(r"^[a-z0-9][a-z0-9\+\.\-]*$", "a\n")
<_sre.SRE_Match object at 0xb7d8a790>

This breaks the generation of the rewritemap file, which breaks codebrowse.

Also, it's clearly not what was intended and just plain horrible.

[Michael Hudson-Doyle (mwhudson)]

Lets please fix this ASAP.

[Michael Hudson-Doyle (mwhudson)]

There's a fix waiting for the db thaw.

[Michael Hudson-Doyle (mwhudson)]

RF 4830.

[Michael Hudson-Doyle (mwhudson)]

Fixed in 1.1.9. I filed bug #144462 (fixing some other constraints that are probably less urgent to fix) and bug #144463 (to test that the situation that led to me discovering this bug is fixed).