rate_of_change should not calculate delta on delta type sample

Bug #1372329 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Invalid
Low
ZhiQiang Fan

Bug Description

When I read the master branch code, I find that in https://github.com/openstack/ceilometer/blob/master/ceilometer/transformer/conversions.py#L129

 volume_delta = (s.volume - prev_volume
                               if (prev_volume <= s.volume or
                                    s.type != sample.TYPE_CUMULATIVE)
                               else s.volume)

which means if a sample is DELTA type, and we apply rate of change on this meter, then the result can be wrong.

However, in current default pipleline, there is no such use case, so this is not found in CI or user test. Since all DELTA type meters come from notifications, I think this might not be triggered in most user cases too. But storage.objects.{incoming,outgoing}.bytes can be exception, and we would never know what third party developers will do, so maybe we should better fix it.

ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Nejc Saje (nejc-saje)
Changed in ceilometer:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/123320

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (master)

Change abandoned by ZhiQiang Fan (<email address hidden>) on branch: master
Review: https://review.openstack.org/123320
Reason: let cloud operator configure it carefully

ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.