add_node_capability and rm_node_capability unable to save changes to db

[Syed Ismail Faizan Barmawer]

The addition of new capability to node.properties by add_node_capability function and removal of capability from node.properties by rm_node_capability function does not get reflected in ironic db even after calling node.save(task.context) at the end of the function.

These functions are defined in ironic/drivers/utils.py module.
The pxe_ilo and ilovemdiaiscsi drivers are impacted with this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/122889

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/122889
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=43ff80b63f4868353143418ea9d6f02b9396a1b0
Submitter: Jenkins
Branch: master

commit 43ff80b63f4868353143418ea9d6f02b9396a1b0
Author: Faizan Barmawer <email address hidden>
Date: Sat Sep 20 10:04:11 2014 +0530

    add_node_capability and rm_node_capability unable to save changes to db

    Changes to elements in existing node.properties dictionary will not get
    saved to database by node.save(context) method. The properties dictionary
    needs to be replaced by a new one to get the changes to be saved in the db.

    Change-Id: I3bb65d00e141aedcb1278c1a700d12c9b29f7232
    Closes-bug:#1371816